Issue 2823 - Display new subscription types on subscriptions page

includes/subscriptionList.tmpl

Index: includes/subscriptionList.tmpl
===================================================================
--- a/includes/subscriptionList.tmpl
+++ b/includes/subscriptionList.tmpl
@@ -17,7 +17,7 @@
 
 {%- macro process_subscription(subscription, parent=None) %}
   <tr{% if subscription["deprecated"] %} class="deprecated"{% endif %}>
-    {%- if subscription["supplements"] %}
+    {%- if parent and subscription["supplements"] %}
       <td rowspan="2" class="dummy"></td>
       <td rowspan="2">
     {%- else %}
@@ -68,20 +68,20 @@
 {%- endmacro %}
 
 {% macro display_subscriptions(subscriptions) %}
-  {%- set current_type = subscriptions[0]["type"] -%}
-  <h2>{{ get_string("type_" + current_type, "subscriptions") }}</h2>
-
-  <table class="subscriptions">
+  {%- set current_type = None -%}

[kzar, 2015/09/15 15:54:55]

Subscriptions always have a type right? If so we can remove this set statement
and check that current_type is truthy instead of that it isn't None.

[Thomas Greiner, 2015/09/16 12:06:28]

Done. It was just a personal preference to make the code more explicit.

   {%- for subscription in subscriptions|subscription_sort -%}
-    {%- if not subscription["supplements"] -%}
+    {%- if not subscription["supplements"] or current_type != subscription["type"] -%}

[kzar, 2015/09/15 15:54:55]

How about an application of De Morgan's law?

{% if not (subscription["supplements"] and current_type == subscription["type"])
%}

[Thomas Greiner, 2015/09/16 12:06:28]

Done. Haven't heard about that theorem yet so thanks for sharing.

       {%- if current_type != subscription["type"] -%}
+        {%- if current_type != None %}

[kzar, 2015/09/15 15:54:55]

Nit: In Python I think you should use `is` for checking if a variable is / isn't
None. If we don't just check for `if current_type` as mentioned above, then I
think we should be doing `if current_type is not None`.

[Thomas Greiner, 2015/09/16 12:06:28]

Done. `is not` was throwing a Jinja2 exception when I tried it out earlier but
checking it like that should be sufficient since I'm no longer explicitly
setting it to `None`.

+  </table>
+        {%- endif -%}
         {%- set current_type = subscription["type"] %}
-  </table>
-
-  <h2>{{ get_string("type_" + current_type, "subscriptions") }}</h2>
+  <h2 id="type_{{ current_type }}">{{ get_string("type_" + current_type, "subscriptions") }}</h2>
 
   <table class="subscriptions">
       {%- endif -%}
+    {%- endif -%}
+    {%- if subscription["type"] not in subscription["supplementsType"] -%}
       {{ process_subscription(subscription) }}
     {%- endif -%}
   {%- endfor %}