Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29326094: Issue 3013 - Replace /en/adblock-browser with a redirect to adblockbrowser.org (Closed)

Created:
Sept. 8, 2015, 11:28 a.m. by Felix Dahlke
Modified:
Sept. 8, 2015, 3:10 p.m.
Reviewers:
saroyanm
Visibility:
Public.

Description

Issue 3013 - Remove /adblock-browser This URL is being redirected to adblockbrowser.org now, so we can remove it from adblockbrowser.org.

Patch Set 1 #

Patch Set 2 : Don't do the client-side redirect #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -284 lines) Patch
M pages/adblock-browser/index.html View 1 1 chunk +0 lines, -284 lines 0 comments Download
R static/img/adblockbrowser_beta_promo.png View Binary file 0 comments Download

Messages

Total messages: 4
Felix Dahlke
Thought a client-side redirect makes most sense here, for now. Not too many people should ...
Sept. 8, 2015, 11:29 a.m. (2015-09-08 11:29:15 UTC) #1
saroyanm
On 2015/09/08 11:29:15, Felix Dahlke wrote: > Thought a client-side redirect makes most sense here, ...
Sept. 8, 2015, 12:55 p.m. (2015-09-08 12:55:24 UTC) #2
Felix Dahlke
On 2015/09/08 12:55:24, saroyanm wrote: > On 2015/09/08 11:29:15, Felix Dahlke wrote: > > Thought ...
Sept. 8, 2015, 3:05 p.m. (2015-09-08 15:05:47 UTC) #3
saroyanm
Sept. 8, 2015, 3:08 p.m. (2015-09-08 15:08:21 UTC) #4
On 2015/09/08 15:05:47, Felix Dahlke wrote:
> On 2015/09/08 12:55:24, saroyanm wrote:
> > On 2015/09/08 11:29:15, Felix Dahlke wrote:
> > > Thought a client-side redirect makes most sense here, for now. Not too
many
> > > people should have gotten this link to begin with.
> > 
> > I don't think that this is a good idea, we should have permanent redirect
> here,
> > also make more sense to do it on serverside, so the user will not download
> other
> > resources before being redirect. If it have to be done on client side we
> should
> > at least send permanent redirect, but still IMO this should be done
> serverside.
> 
> Alright, went for a real redirect: https://issues.adblockplus.org/ticket/3013
> 
> Updated this review to only remove the stuff that's now obsolete.

LGTM

Powered by Google App Engine
This is Rietveld