Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(237)

Issue 29326122: Issue 3015 - Remove legacy code for Adblock Browser from submit_email (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by Sebastian Noack
Modified:
4 years, 2 months ago
Reviewers:
Felix Dahlke
CC:
Wladimir Palant, kzar, saroyanm
Visibility:
Public.

Description

Issue 3015 - Remove legacy code for Adblock Browser from submit_email

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -44 lines) Patch
M .sitescripts.example View 1 chunk +0 lines, -2 lines 0 comments Download
R sitescripts/submit_email/template/verification.mail View 1 chunk +0 lines, -31 lines 0 comments Download
M sitescripts/submit_email/web/submit_email.py View 1 6 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
4 years, 2 months ago (2015-09-08 13:37:39 UTC) #1
Felix Dahlke
LGTM with some typos. https://codereview.adblockplus.org/29326122/diff/29326123/sitescripts/submit_email/web/submit_email.py File sitescripts/submit_email/web/submit_email.py (right): https://codereview.adblockplus.org/29326122/diff/29326123/sitescripts/submit_email/web/submit_email.py#newcode44 sitescripts/submit_email/web/submit_email.py:44: return send_simple_response(start_response, 400, 'Unkown product') ...
4 years, 2 months ago (2015-09-08 13:44:21 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29326122/diff/29326123/sitescripts/submit_email/web/submit_email.py File sitescripts/submit_email/web/submit_email.py (right): https://codereview.adblockplus.org/29326122/diff/29326123/sitescripts/submit_email/web/submit_email.py#newcode44 sitescripts/submit_email/web/submit_email.py:44: return send_simple_response(start_response, 400, 'Unkown product') On 2015/09/08 13:44:21, Felix ...
4 years, 2 months ago (2015-09-08 14:09:43 UTC) #3
Felix Dahlke
4 years, 2 months ago (2015-09-08 14:15:14 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5