Issue 3022 - Implemented new notification type for normal messages

lib/notificationHelper.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 24 matching lines @@
     if (navigator.platform.indexOf("Linux") == -1)
       return true;
     if (Services.vc.compare(info.applicationVersion, "35") >= 0)
       return true;
   }
   return false;
 })();
 
 function prepareNotificationIconAndPopup()
 {
-  let animateIcon = (activeNotification.type != "question");
+  let animateIcon = (activeNotification.type == "critical"

[Sebastian Noack, 2015/09/09 13:35:36]

I wonder whether we should use global objects used as set, to configure the
notification types to be animated, and types to trigger a desktop notification
below. Then you'd have less complexity here, and can simply use the in-operator.

[Thomas Greiner, 2015/09/09 15:32:36]

Done. However, I decided to implement a function to avoid duplication of
fallback-to-default logic and to avoid having to share the entire structure with
notification.js.

+    || activeNotification.type == "information");
   activeNotification.onClicked = function()
   {
     if (animateIcon)
       stopIconAnimation();
     notificationClosed();
   };
   if (animateIcon)
     startIconAnimation(activeNotification.type);
 }
 
@@ skipping 72 matching lines @@
   chrome.notifications.onClicked.addListener(clearActiveNotification);
   chrome.notifications.onClosed.addListener(notificationClosed);
 }
 
 function showNotification(notification)
 {
   if (activeNotification && activeNotification.id == notification.id)
     return;
 
   activeNotification = notification;
-  if (activeNotification.type == "critical" || activeNotification.type == "question")
+  if (activeNotification.type == "critical"
+    || activeNotification.type == "question"
+    || activeNotification.type == "normal")
   {
     let texts = NotificationStorage.getLocalizedTexts(notification);
     let title = texts.title || "";
     let message = texts.message ? texts.message.replace(/<\/?(a|strong)>/g, "") : "";
     let iconUrl = ext.getURL("icons/detailed/abp-128.png");
     let hasLinks = activeNotification.links && activeNotification.links.length > 0;
 
     if (canUseChromeNotifications)
     {
       let opts = {
@@ skipping 84 matching lines @@
  * Gets the active notification to be shown if any.
  *
  * @return {?object}
  */
 exports.getActiveNotification = function()
 {
   return activeNotification;
 };
 
 NotificationStorage.addShowListener(showNotification);