Issue 3022 - Implemented new notification type for normal messages

lib/notificationHelper.js

Index: lib/notificationHelper.js
===================================================================
--- a/lib/notificationHelper.js
+++ b/lib/notificationHelper.js
@@ -42,7 +42,8 @@
 
 function prepareNotificationIconAndPopup()
 {
-  let animateIcon = (activeNotification.type != "question");
+  let animateIcon = (activeNotification.type == "critical"

[Sebastian Noack, 2015/09/09 13:35:36]

I wonder whether we should use global objects used as set, to configure the
notification types to be animated, and types to trigger a desktop notification
below. Then you'd have less complexity here, and can simply use the in-operator.

[Thomas Greiner, 2015/09/09 15:32:36]

Done. However, I decided to implement a function to avoid duplication of
fallback-to-default logic and to avoid having to share the entire structure with
notification.js.

+    || activeNotification.type == "information");
   activeNotification.onClicked = function()
   {
     if (animateIcon)
@@ -135,7 +136,9 @@
     return;
 
   activeNotification = notification;
-  if (activeNotification.type == "critical" || activeNotification.type == "question")
+  if (activeNotification.type == "critical"
+    || activeNotification.type == "question"
+    || activeNotification.type == "normal")
   {
     let texts = NotificationStorage.getLocalizedTexts(notification);
     let title = texts.title || "";