Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(420)

Issue 29326213: Issue 3039 - Generate qunit/index.html based on metadata (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by kzar
Modified:
4 years, 4 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 3039 - Generate qunit/index.html based on metadata

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove JQuery which we're not using and qunit.js which is now hard coded into the template #

Patch Set 3 : Updated buildtools dependency again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -54 lines) Patch
M dependencies View 1 2 1 chunk +1 line, -1 line 0 comments Download
M metadata.common View 1 1 chunk +18 lines, -0 lines 0 comments Download
D qunit/index.html View 1 chunk +0 lines, -53 lines 0 comments Download

Messages

Total messages: 7
kzar
Patch Set 1
4 years, 4 months ago (2015-09-09 17:49:03 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29326213/diff/29326214/metadata.common File metadata.common (right): https://codereview.adblockplus.org/29326213/diff/29326214/metadata.common#newcode18 metadata.common:18: qunit.js Argh. I think this should be hard-coded in ...
4 years, 4 months ago (2015-09-09 17:56:51 UTC) #2
kzar
https://codereview.adblockplus.org/29326213/diff/29326214/metadata.common File metadata.common (right): https://codereview.adblockplus.org/29326213/diff/29326214/metadata.common#newcode18 metadata.common:18: qunit.js On 2015/09/09 17:56:51, Sebastian Noack wrote: > Argh. ...
4 years, 4 months ago (2015-09-09 18:01:00 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29326213/diff/29326214/metadata.common File metadata.common (right): https://codereview.adblockplus.org/29326213/diff/29326214/metadata.common#newcode18 metadata.common:18: qunit.js On 2015/09/09 18:01:00, kzar wrote: > On 2015/09/09 ...
4 years, 4 months ago (2015-09-09 18:08:37 UTC) #4
Sebastian Noack
LGTM
4 years, 4 months ago (2015-09-09 18:08:55 UTC) #5
kzar
Patch Set 3 : Updated buildtools dependency again
4 years, 4 months ago (2015-09-09 18:16:44 UTC) #6
Sebastian Noack
4 years, 4 months ago (2015-09-09 18:18:38 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5