metadata.common - Issue 29326213: Issue 3039 - Generate qunit/index.html based on metadata

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: metadata.common

Issue 29326213: Issue 3039 - Generate qunit/index.html based on metadata (Closed)

Patch Set: Created Sept. 9, 2015, 5:48 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 [general]	1 [general]

2 version = 1.9.2	2 version = 1.9.2

3 backgroundScripts = ext/common.js	3 backgroundScripts = ext/common.js

4 ext/background.js	4 ext/background.js

5 lib/compat.js	5 lib/compat.js

6 lib/info.js	6 lib/info.js

7 lib/adblockplus.js	7 lib/adblockplus.js

8 lib/punycode.js	8 lib/punycode.js

9 lib/publicSuffixList.js	9 lib/publicSuffixList.js

10 lib/sha1.js	10 lib/sha1.js

11 lib/jsbn.js	11 lib/jsbn.js

12 lib/rsa.js	12 lib/rsa.js

13 webrequest.js	13 webrequest.js

14 messageResponder.js	14 messageResponder.js

15 popupBlocker.js	15 popupBlocker.js

16 background.js	16 background.js

	17 testScripts = ../jquery-ui/js/jquery-1.7.1.min.js

	18 qunit.js
	Sebastian Noack 2015/09/09 17:56:51 Argh. I think this should be hard-coded in the tem Argh. I think this should be hard-coded in the template, along with qunit.css and the qunit-specific markup. kzar 2015/09/09 18:01:00 I can do that, but JQuery will also need to be har Show quoted text On 2015/09/09 17:56:51, Sebastian Noack wrote: > Argh. I think this should be hard-coded in the template, along with qunit.css > and the qunit-specific markup. I can do that, but JQuery will also need to be hard-coded in that case if we want to preserve the ordering. Actually, I've just tested and apparently we don't even need JQuery. I'll remove it at the same time unless you have any objections. Sebastian Noack 2015/09/09 18:08:37 jQuery shouldn't be required by qunit, at least no Show quoted text On 2015/09/09 18:01:00, kzar wrote: > On 2015/09/09 17:56:51, Sebastian Noack wrote: > > Argh. I think this should be hard-coded in the template, along with qunit.css > > and the qunit-specific markup. > > I can do that, but JQuery will also need to be hard-coded in that case if we > want to preserve the ordering. > > Actually, I've just tested and apparently we don't even need JQuery. I'll remove > it at the same time unless you have any objections. jQuery shouldn't be required by qunit, at least not in the version we use or any newer version. We use jQuery in some legacy UI code though. However, doesn't seem any of these is loaded here. And even if, we could list jQuery just below qunit. So there wouldn't be any need to hard-code it.
	19 ../ext/common.js

	20 ../ext/background.js

	21 ../lib/compat.js

	22 ../lib/info.js

	23 ../lib/io.js

	24 ../lib/adblockplus.js

	25 ../lib/publicSuffixList.js

	26 ../lib/punycode.js

	27 ../lib/sha1.js

	28 ../lib/jsbn.js

	29 ../lib/rsa.js

	30 ../webrequest.js

	31 common.js

	32 tests/adblockplus.js

	33 tests/versionComparator.js

	34 tests/url.js

	35 tests/signatures.js

	36 tests/cssEscaping.js

17 permissions = http:/// https:///	37 permissions = http:/// https:///

18	38

19 [contentScripts]	39 [contentScripts]

20 document_start = ext/common.js ext/content.js include.preload.js	40 document_start = ext/common.js ext/content.js include.preload.js

21 document_end = include.postload.js	41 document_end = include.postload.js

22	42

23 [mapping]	43 [mapping]

24 ext/content.js = chrome/ext/content.js	44 ext/content.js = chrome/ext/content.js

25 ext/popup.js = chrome/ext/popup.js	45 ext/popup.js = chrome/ext/popup.js

26 subscriptions.xml = adblockplus/chrome/content/ui/subscriptions.xml	46 subscriptions.xml = adblockplus/chrome/content/ui/subscriptions.xml

(...skipping 81 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
108 addSubscription.label	128 addSubscription.label

109 addSubscriptionAdd.label	129 addSubscriptionAdd.label

110 addSubscriptionOther.label	130 addSubscriptionOther.label

111 acceptableAds2.label	131 acceptableAds2.label

112 viewList.label	132 viewList.label

113 readMore.label	133 readMore.label

114 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label	134 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label

115 title.label	135 title.label

116 adblockplus/chrome/locale/*/meta.properties = =name	136 adblockplus/chrome/locale/*/meta.properties = =name

117 adblockplusui/locale//firstRun.json = =	137 adblockplusui/locale//firstRun.json = =

OLD	NEW

« no previous file with comments | « dependencies ('k') | qunit/index.html » ('j') | no next file with comments »