Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: firstRun.html

Issue 29326238: Issue 3031 - Add Adblock Browser section to First Run Page (Closed)
Patch Set: Removed block for French locale Created Sept. 10, 2015, 9:55 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | locale/en-US/firstRun.json » ('j') | skin/firstRun.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-2015 Eyeo GmbH 4 - Copyright (C) 2006-2015 Eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 21 matching lines...) Expand all
32 <header> 32 <header>
33 <img id="logo"> 33 <img id="logo">
34 <h1 id="title-main" class="i18n_firstRun_title"></h1> 34 <h1 id="title-main" class="i18n_firstRun_title"></h1>
35 </header> 35 </header>
36 36
37 <section id="legacySafariWarning" class="i18n_firstRun_legacySafariWarning w arning" hidden="true"></section> 37 <section id="legacySafariWarning" class="i18n_firstRun_legacySafariWarning w arning" hidden="true"></section>
38 <section id="filterlistsReinitializedWarning" class="i18n_firstRun_filterlis tsReinitializedWarning warning" hidden="true"></section> 38 <section id="filterlistsReinitializedWarning" class="i18n_firstRun_filterlis tsReinitializedWarning warning" hidden="true"></section>
39 <section id="dataCorruptionWarning" class="i18n_firstRun_dataCorruptionWarni ng warning" hidden="true"></section> 39 <section id="dataCorruptionWarning" class="i18n_firstRun_dataCorruptionWarni ng warning" hidden="true"></section>
40 40
41 <div id="content"> 41 <div id="content">
42 <section id="acceptable-ads"> 42 <section id="general">
43 <h2 class="i18n_firstRun_acceptableAdsHeadline"></h2> 43 <div id="acceptable-ads-block">
Thomas Greiner 2015/09/11 18:11:59 Detail: There's no need to change the ID of this e
saroyanm 2015/09/15 09:42:37 I tried to make the consistent, in the share secti
44 <p id="acceptableAdsExplanation" class="i18n_firstRun_acceptableAdsExpla nation"></p> 44 <h2 class="i18n_firstRun_acceptableAdsHeadline"></h2>
45 <p id="acceptableAdsExplanation" class="i18n_firstRun_acceptableAdsExp lanation"></p>
Thomas Greiner 2015/09/11 18:11:59 Detail: Inconsistent naming of element IDs.
saroyanm 2015/09/15 09:42:37 I guess you mean the dashes separation ? Done. Ple
46 </div>
47 <div id="abb-promotion-block">
48 <h2 class="i18n_firstRun_abbPromotionHeadline"></h2>
49 <a href="https://adblockbrowser.org/?ref=frp">
50 <div>
51 <img src="skin/abb-logo.png" alt="Adblock Browser logo" />
52 </div>
53 <div>
54 <div class="i18n_firstRun_abbButtonText1"></div>
55 <div class="i18n_firstRun_abbButtonText2"></div>
56 </div>
57 </a>
58 </div>
45 </section> 59 </section>
46 60
47 61
48 <section id="share"> 62 <section id="share">
49 <h2 id="share-headline" class="i18n_firstRun_share_headline"></h2> 63 <h2 id="share-headline" class="i18n_firstRun_share_headline"></h2>
50 64
51 <div id="donate-block"> 65 <div id="donate-block">
52 <a id="donate" class="i18n_firstRun_donate" target="_blank"></a> 66 <a id="donate" class="i18n_firstRun_donate" target="_blank"></a>
53 <span id="donate-label" class="i18n_firstRun_donate_label"></span> 67 <span id="donate-label" class="i18n_firstRun_donate_label"></span>
54 </div> 68 </div>
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 <footer> 148 <footer>
135 <a id="contributors" class="i18n_firstRun_contributor_credits"></a> 149 <a id="contributors" class="i18n_firstRun_contributor_credits"></a>
136 </footer> 150 </footer>
137 151
138 152
139 <div id="glass-pane"> 153 <div id="glass-pane">
140 <iframe id="share-popup" scrolling="no"></iframe> 154 <iframe id="share-popup" scrolling="no"></iframe>
141 </div> 155 </div>
142 </body> 156 </body>
143 </html> 157 </html>
OLDNEW
« no previous file with comments | « no previous file | locale/en-US/firstRun.json » ('j') | skin/firstRun.css » ('J')

Powered by Google App Engine
This is Rietveld