Issue 3031 - Add Adblock Browser section to First Run Page

skin/firstRun.css

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 121 matching lines @@
   font-weight: normal;
   text-align: center;
   margin: 0;
   padding: 0;
 }
 
 section
 {
   margin: 0 auto;
   margin-bottom: 30px;
-  max-width: 760px;
+  max-width: 960px;
   background-image: url(background.png);
   padding: 40px 100px;
 }
 
 #general
 {
   padding: 40px 0px;
-  max-width: 960px;
   display: table;
 }
 
 #general > div
 {
   display: table-cell;
   width: 50%;
   vertical-align: top;
   padding: 0px 50px;
-}
-
-#general > div:not(:first-child)
-{
-  border-left: dashed 1px #969085;
-}
-
-html[dir="rtl"] #general > div:not(:first-child)
-{
-  border-left: none;
-  border-right: dashed 1px #969085;
+  border: dashed 0 #969085;
+  -webkit-border-start-width: 1px;
+  -moz-border-start-width: 1px;
+  border-inline-start-width: 1px;
+}
+
+#general > div:first-child
+{
+  border: none;
 }
 
 #acceptable-ads-block h2
 {
   margin-bottom: 34px;
 }
 
 #abb-promotion-block:lang(fr)
 {
   display: none;
+}
+
+#abb-promotion-block
+{
+  text-align: center;
 }
 
 #abb-promotion-block h2
 {
   color: #7795b6;
   margin-bottom: 40px;
 }
 
 #abb-promotion-block a
 {
   border: solid 1px #446a96;
   border-radius: 5px;
-  display: table;
+  display: inline-block;
   padding: 6px 16px;
-  background: -webkit-gradient(to top, #294e76, #6b92be);

[Thomas Greiner, 2015/09/15 11:19:32]

Two more issues:

1) According to MDN Safari 5.1 requires `-webkit-xxx` but without support for
the `to xxx` syntax.
2) It should be `-webkit-linear-gradient` and not `-webkit-gradient`.

[saroyanm, 2015/09/15 12:43:31]

Done.

[Thomas Greiner, 2015/09/15 14:15:50]

Nope, while the `to X` syntax defines to which point a gradient should flow, the
old syntax defines where it originates. Therefore you need to either change
"top" to "bottom" or reverse the order of the color values.

See also
https://developer.mozilla.org/en-US/docs/Web/CSS/linear-gradient#History_of_t...

"Unfortunately, the addition of the <angle> values to the syntax introduced an
incoherence: the angle indicates a destination, but the keywords indicate a
starting point.# This was fixed by a new syntax where the keyword are directions
too, and preceded by the to keyword."

[saroyanm, 2015/09/15 15:03:35]

Good to know, thanks. 
Made it somehow consistent with other implementation on the page, not sure
whether make to also remove -moz prefixes from similar implementation of toggle
buttons styles on line 663 and 667.

+  background: -webkit-linear-gradient(bottom, #294e76, #6b92be);
   background: linear-gradient(to top, #294e76, #6b92be);
   text-decoration: none;
-  width: 100%;
-  -webkit-box-sizing: border-box;
-  -moz-box-sizing: border-box;
-  box-sizing: border-box;
+  text-align: start;
 }
 
 #abb-promotion-block a > div
 {
   display: table-cell;
   vertical-align: middle;
   padding: 6px;
 }
 
-#abb-promotion-block a > div:first-child
-{
-  width: 1px;
-}
-
 #abb-promotion-block .title
 {
-  font-size: 22px;

[Thomas Greiner, 2015/09/15 11:19:31]

This font size causes the text to be split up into two lines. I checked back
with Sven and reducing it to `21px` would be a quick workaround to at least
ensure that the english version of the text stays in one line.

[saroyanm, 2015/09/15 12:43:31]

Done.

+  font-size: 21px;
   color: #ffffff;
   font-weight: bold;
 }
 
 #abb-promotion-block .subtitle
 {
   font-size: 12px;
   color: #9ab7d6;
 }
 
 #abb-promotion-block a:hover
 {
-  -moz-box-shadow: 0px 0px 5px #5D5D5D;
-  -webkit-box-shadow: 0px 0px 5px #5D5D5D;
   box-shadow: 0px 0px 5px #5D5D5D;
 }
 
 #abb-promotion-block a:active
 {
-  -moz-box-shadow: 0px 0px 5px 1px #5D5D5D;
-  -webkit-box-shadow: 0px 0px 5px 1px #5D5D5D;
   box-shadow: 0px 0px 5px 1px #5D5D5D;
 }
 
 @media (max-width: 960px)
 {
   #general
   {
     display: block;
   }
 
-  #general > div:not(:first-child),
-  html[dir="rtl"] #general > div:not(:first-child)
-  {
-    border: none;
-  }
-
   #general > div
   {
     display: block;
     width: auto;
+    padding: 10px 0px;
+    margin: 0px 50px;
+    border-width: 1px 0 0;
   }
 }
 
 section > p
 {
   margin: 15px 0 0 0;
 }
 
 #logo
 {
   margin: 0 auto;
   height: 128px;
   width: 128px;
   display: block;
 }
 
 #can-do-more
 {
-  max-width: 960px;
   padding: 40px 0px 0px 0px;
   border-bottom: 4px solid #968D81;
 }
 
 #can-do-more > h2
 {
   margin: 0 100px;
 }
 
 .feature-malware-image
@@ skipping 419 matching lines @@
   background-image: url(donate.png);
   background-repeat: repeat-x;
 }
 
 footer
 {
   margin: 0 auto 30px;
   max-width: 960px;
   text-align: center;
 }