Issue 29327142: Issue 3031 - Add Adblock Browser section to First Run Page (localization)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+492 lines, -6 lines)			Patch
M	locale/ar/firstRun.json	View	1 2 3 4 5 6	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/ast/firstRun.json	View	1 2 3	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/bg/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/bn-BD/firstRun.json	View	1 2 3 4 5	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/bs/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/ca/firstRun.json	View	1 2 3 4 5 6	2 chunks	+11 lines, -2 lines	0 comments	Download
M	locale/cs/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/da/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/de/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/el/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/en-US/firstRun.json	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	locale/es-AR/firstRun.json	View	1 2 3 4 5 6	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/es-CL/firstRun.json	View	1 2 3 4 5 6	1 chunk	+10 lines, -1 line	0 comments	Download
M	locale/es-ES/firstRun.json	View	1 2 3 4 5 6	1 chunk	+10 lines, -1 line	0 comments	Download
M	locale/es-MX/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/et/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/eu/firstRun.json	View	1 2 3	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/fa/firstRun.json	View	1 2 3 4 5	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/fi/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/fr/firstRun.json	View	1 2 4	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/he/firstRun.json	View	1 2 3 4 5	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/hi-IN/firstRun.json	View	1 2 3 4 5 6	1 chunk	+10 lines, -1 line	0 comments	Download
M	locale/hr/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/hu/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/hy-AM/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/id/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/is/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/it/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/ja/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/kk/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/ko/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/lt/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/lv/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/mk/firstRun.json	View	1 2 3 4 5	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/mr/firstRun.json	View	1 2 3 4 5	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/ms/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/nb-NO/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/nl/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/pl/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/pt-BR/firstRun.json	View	1 2 3 4 5 6	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/pt-PT/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/ro/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/ru/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/sk/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/sl/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/sq/firstRun.json	View	1 2 3 4 5 6 7	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/sr/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/sv-SE/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/ta-LK/firstRun.json	View	1 2 3	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/th/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/tr/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/uk/firstRun.json	View	1 2 3 4 5	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/vi/firstRun.json	View	1 2 3 4 5	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/zh-CN/firstRun.json	View	1 2 3 4 5	1 chunk	+9 lines, -0 lines	0 comments	Download
M	locale/zh-TW/firstRun.json	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 26

Expand All Messages | Collapse All Messages

saroyanm

Phill can you please have a look, I couldn't find locales for current languages: https://www.onehourtranslation.com/project/VG3813274/ ...

Sept. 10, 2015, 2:46 p.m. (2015-09-10 14:46:38 UTC) #1

Sebastian Noack

https://codereview.adblockplus.org/29327142/diff/29327143/locale/ar/firstRun.json File locale/ar/firstRun.json (right): https://codereview.adblockplus.org/29327142/diff/29327143/locale/ar/firstRun.json#newcode12 locale/ar/firstRun.json:12: "message": "احصل على Adblock Browserهنا" I think there is ...

Sept. 11, 2015, 11:53 a.m. (2015-09-11 11:53:57 UTC) #2

saroyanm

Sept. 11, 2015, 12:51 p.m. (2015-09-11 12:51:27 UTC) #3

Philip Hill

On 2015/09/10 14:46:38, saroyanm wrote: > Phill can you please have a look, I couldn't ...

Sept. 11, 2015, 1:06 p.m. (2015-09-11 13:06:15 UTC) #4

Philip Hill

https://codereview.adblockplus.org/29327142/diff/29327143/locale/ast/firstRun.json File locale/ast/firstRun.json (right): https://codereview.adblockplus.org/29327142/diff/29327143/locale/ast/firstRun.json#newcode7 locale/ast/firstRun.json:7: }, Since this locale turns out to be Spanish ...

Sept. 11, 2015, 1:06 p.m. (2015-09-11 13:06:36 UTC) #5

Sebastian Noack

On 2015/09/11 13:06:15, Philip Hill wrote: > I wonder if it makes any difference to ...

Sept. 11, 2015, 1:30 p.m. (2015-09-11 13:30:04 UTC) #6

On 2015/09/11 13:06:15, Philip Hill wrote:
> I wonder if it makes any difference to add the US English to the UK English
> translations, or if there is a fallback to US English either way.

Yeah, we fallback to US English anyway. Moreover, some time ago I had Dave
review our US English texts, and he couldn't spot anything that he would phrase
differently in British English, anyway.

https://codereview.adblockplus.org/29327142/diff/29327143/locale/ar/firstRun....
File locale/ar/firstRun.json (right):

https://codereview.adblockplus.org/29327142/diff/29327143/locale/ar/firstRun....
locale/ar/firstRun.json:12: "message": "احصل على Adblock Browserهنا"
On 2015/09/11 12:51:25, saroyanm wrote:
> On 2015/09/11 11:53:55, Sebastian Noack wrote:
> > I think there is a space missing before "Adblock Browser"
> 
> No there is no space, I think it feels so because of Arabic character,
actually
> I'm not sure whether there should be space after Adblock Browser, but I'd
avoid
> of adding space, because it could be a special language feature.

Arabic is read from the right to the left, so:

right = before
left = after

And yes, I meant adding a space to the right, which is before "Adblock Browser".

https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstR...
File locale/bn-BD/firstRun.json (right):

https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstR...
locale/bn-BD/firstRun.json:9: "message": "অ্যান্ড্রয়েড ও iOS-এর জন্য উপলভ্য"
On 2015/09/11 12:51:25, saroyanm wrote:
> On 2015/09/11 11:53:56, Sebastian Noack wrote:
> > I doubt that Android is supposed to be translated here, while iOS and
"ADblock
> > Browser" aren't.
> 
> I don't think that it would be possible to check all the language specific
> mistakes I do think that it's something that translators should take care
about,
> because I'm pretty sure there are more inconsistency in the translations, than
> just missing Android, I've noticed most of them also are translating word
> "Browser" while the description clearly says "Please don't translate "Adblock
> Browser", since that is our fixed product name.".

Yes, in particular translation agencies, tend to deliver inconsistent and bad
translations. Their translators don't know the product and the context. And
therefore we need to verify their translations.

saroyanm

Sept. 11, 2015, 1:45 p.m. (2015-09-11 13:45:16 UTC) #7

https://codereview.adblockplus.org/29327142/diff/29327143/locale/ar/firstRun....
File locale/ar/firstRun.json (right):

https://codereview.adblockplus.org/29327142/diff/29327143/locale/ar/firstRun....
locale/ar/firstRun.json:12: "message": "احصل على Adblock Browserهنا"
On 2015/09/11 13:30:03, Sebastian Noack wrote:
> On 2015/09/11 12:51:25, saroyanm wrote:
> > On 2015/09/11 11:53:55, Sebastian Noack wrote:
> > > I think there is a space missing before "Adblock Browser"
> > 
> > No there is no space, I think it feels so because of Arabic character,
> actually
> > I'm not sure whether there should be space after Adblock Browser, but I'd
> avoid
> > of adding space, because it could be a special language feature.
> 
> Arabic is read from the right to the left, so:
> 
> right = before
> left = after
> 
> And yes, I meant adding a space to the right, which is before "Adblock
Browser".

Ahh right :) Done. But in general I'd avoid doing lagnuage specific changes, bit
tricky IMO.

https://codereview.adblockplus.org/29327142/diff/29327143/locale/ast/firstRun...
File locale/ast/firstRun.json (right):

https://codereview.adblockplus.org/29327142/diff/29327143/locale/ast/firstRun...
locale/ast/firstRun.json:7: },
On 2015/09/11 13:06:34, Philip Hill wrote:
> Since this locale turns out to be Spanish from Asturias, we can add regular
> Spanish.

Done.

https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstR...
File locale/bn-BD/firstRun.json (right):

https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstR...
locale/bn-BD/firstRun.json:9: "message": "অ্যান্ড্রয়েড ও iOS-এর জন্য উপলভ্য"
On 2015/09/11 13:30:03, Sebastian Noack wrote:
> On 2015/09/11 12:51:25, saroyanm wrote:
> > On 2015/09/11 11:53:56, Sebastian Noack wrote:
> > > I doubt that Android is supposed to be translated here, while iOS and
> "ADblock
> > > Browser" aren't.
> > 
> > I don't think that it would be possible to check all the language specific
> > mistakes I do think that it's something that translators should take care
> about,
> > because I'm pretty sure there are more inconsistency in the translations,
than
> > just missing Android, I've noticed most of them also are translating word
> > "Browser" while the description clearly says "Please don't translate
"Adblock
> > Browser", since that is our fixed product name.".
> 
> Yes, in particular translation agencies, tend to deliver inconsistent and bad
> translations. Their translators don't know the product and the context. And
> therefore we need to verify their translations.

So I see 2 options:
* Check all translations with similar porblem, come back to Translators asking
to fix.
* Push the changes and modify them afterward.

While I thought it's a priority project, maybe make sense to go with second
option ?

https://codereview.adblockplus.org/29327142/diff/29327143/locale/eu/firstRun....
File locale/eu/firstRun.json (right):

https://codereview.adblockplus.org/29327142/diff/29327143/locale/eu/firstRun....
locale/eu/firstRun.json:7: },
On 2015/09/11 13:06:34, Philip Hill wrote:
> This is basque, which we do have available:
> 
> Smartphone edo tablet-a duzu?
> 
> Eskuratu Adblock Browser hemen
> 
> Android eta iOS-entzat

Done.

https://codereview.adblockplus.org/29327142/diff/29327143/locale/fr/firstRun....
File locale/fr/firstRun.json (right):

https://codereview.adblockplus.org/29327142/diff/29327143/locale/fr/firstRun....
locale/fr/firstRun.json:8: "firstRun_abbPromotionHeadline": {
On 2015/09/11 13:06:35, Philip Hill wrote:
> According to the ticket, the change shall explicitly NOT "be performed for the
> French version of the FRP".

Yes you are right, Reverted.

https://codereview.adblockplus.org/29327142/diff/29327143/locale/ta-LK/firstR...
File locale/ta-LK/firstRun.json (right):

https://codereview.adblockplus.org/29327142/diff/29327143/locale/ta-LK/firstR...
locale/ta-LK/firstRun.json:3: "message": "எரிச்சலூட்டும் விளம்பரங்கள் இப்போது
தடைசெய்யப்படும்"
On 2015/09/11 13:06:35, Philip Hill wrote:
> We do have a Tamil translation:
> 
> ஸ்மார்ட்ஃபோன் அல்லது டேப்ளெட் வைத்திருக்கிறீர்களா?
> 
> Adblock Browser-ஐ இங்கே பெற்றிடுங்கள்
> 
> ஆண்ட்ராய்டு மற்றும் iOS-க்குக் கிடைக்கிறது

Done.

Sebastian Noack

https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstRun.json File locale/bn-BD/firstRun.json (right): https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstRun.json#newcode9 locale/bn-BD/firstRun.json:9: "message": "অ্যান্ড্রয়েড ও iOS-এর জন্য উপলভ্য" On 2015/09/11 13:45:13, ...

Sept. 11, 2015, 1:48 p.m. (2015-09-11 13:48:43 UTC) #8

https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstR...
File locale/bn-BD/firstRun.json (right):

https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstR...
locale/bn-BD/firstRun.json:9: "message": "অ্যান্ড্রয়েড ও iOS-এর জন্য উপলভ্য"
On 2015/09/11 13:45:13, saroyanm wrote:
> On 2015/09/11 13:30:03, Sebastian Noack wrote:
> > On 2015/09/11 12:51:25, saroyanm wrote:
> > > On 2015/09/11 11:53:56, Sebastian Noack wrote:
> > > > I doubt that Android is supposed to be translated here, while iOS and
> > "ADblock
> > > > Browser" aren't.
> > > 
> > > I don't think that it would be possible to check all the language specific
> > > mistakes I do think that it's something that translators should take care
> > about,
> > > because I'm pretty sure there are more inconsistency in the translations,
> than
> > > just missing Android, I've noticed most of them also are translating word
> > > "Browser" while the description clearly says "Please don't translate
> "Adblock
> > > Browser", since that is our fixed product name.".
> > 
> > Yes, in particular translation agencies, tend to deliver inconsistent and
bad
> > translations. Their translators don't know the product and the context. And
> > therefore we need to verify their translations.
> 
> So I see 2 options:
> * Check all translations with similar porblem, come back to Translators asking
> to fix.
> * Push the changes and modify them afterward.
> 
> While I thought it's a priority project, maybe make sense to go with second
> option ?

Well, I did check all translations for similar issues, and left comments where I
found something. But yeah, in the long term we really need a dedicated
translation manager for that stuff.

https://codereview.adblockplus.org/29327142/diff/29327143/locale/fr/firstRun....
File locale/fr/firstRun.json (right):

https://codereview.adblockplus.org/29327142/diff/29327143/locale/fr/firstRun....
locale/fr/firstRun.json:8: "firstRun_abbPromotionHeadline": {
On 2015/09/11 13:45:13, saroyanm wrote:
> On 2015/09/11 13:06:35, Philip Hill wrote:
> > According to the ticket, the change shall explicitly NOT "be performed for
the
> > French version of the FRP".
> 
> Yes you are right, Reverted.

Well, since we have the translation now anyway, it wouldn't hurt adding it. In
case we change our mind later.

Philip Hill

On 2015/09/11 13:48:43, Sebastian Noack wrote: > https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstRun.json > File locale/bn-BD/firstRun.json (right): > > https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstRun.json#newcode9 ...

Sept. 11, 2015, 1:50 p.m. (2015-09-11 13:50:10 UTC) #9

On 2015/09/11 13:48:43, Sebastian Noack wrote:
>
https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstR...
> File locale/bn-BD/firstRun.json (right):
> 
>
https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstR...
> locale/bn-BD/firstRun.json:9: "message": "অ্যান্ড্রয়েড ও iOS-এর জন্য উপলভ্য"
> On 2015/09/11 13:45:13, saroyanm wrote:
> > On 2015/09/11 13:30:03, Sebastian Noack wrote:
> > > On 2015/09/11 12:51:25, saroyanm wrote:
> > > > On 2015/09/11 11:53:56, Sebastian Noack wrote:
> > > > > I doubt that Android is supposed to be translated here, while iOS and
> > > "ADblock
> > > > > Browser" aren't.
> > > > 
> > > > I don't think that it would be possible to check all the language
specific
> > > > mistakes I do think that it's something that translators should take
care
> > > about,
> > > > because I'm pretty sure there are more inconsistency in the
translations,
> > than
> > > > just missing Android, I've noticed most of them also are translating
word
> > > > "Browser" while the description clearly says "Please don't translate
> > "Adblock
> > > > Browser", since that is our fixed product name.".
> > > 
> > > Yes, in particular translation agencies, tend to deliver inconsistent and
> bad
> > > translations. Their translators don't know the product and the context.
And
> > > therefore we need to verify their translations.
> > 
> > So I see 2 options:
> > * Check all translations with similar porblem, come back to Translators
asking
> > to fix.
> > * Push the changes and modify them afterward.
> > 
> > While I thought it's a priority project, maybe make sense to go with second
> > option ?
> 
> Well, I did check all translations for similar issues, and left comments where
I
> found something. But yeah, in the long term we really need a dedicated
> translation manager for that stuff.
> 
>
https://codereview.adblockplus.org/29327142/diff/29327143/locale/fr/firstRun....
> File locale/fr/firstRun.json (right):
> 
>
https://codereview.adblockplus.org/29327142/diff/29327143/locale/fr/firstRun....
> locale/fr/firstRun.json:8: "firstRun_abbPromotionHeadline": {
> On 2015/09/11 13:45:13, saroyanm wrote:
> > On 2015/09/11 13:06:35, Philip Hill wrote:
> > > According to the ticket, the change shall explicitly NOT "be performed for
> the
> > > French version of the FRP".
> > 
> > Yes you are right, Reverted.
> 
> Well, since we have the translation now anyway, it wouldn't hurt adding it. In
> case we change our mind later.

Other than that, LGTM

saroyanm

Sept. 11, 2015, 1:56 p.m. (2015-09-11 13:56:03 UTC) #11

https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstR...
File locale/bn-BD/firstRun.json (right):

https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstR...
locale/bn-BD/firstRun.json:9: "message": "অ্যান্ড্রয়েড ও iOS-এর জন্য উপলভ্য"
On 2015/09/11 13:48:43, Sebastian Noack wrote:
> On 2015/09/11 13:45:13, saroyanm wrote:
> > On 2015/09/11 13:30:03, Sebastian Noack wrote:
> > > On 2015/09/11 12:51:25, saroyanm wrote:
> > > > On 2015/09/11 11:53:56, Sebastian Noack wrote:
> > > > > I doubt that Android is supposed to be translated here, while iOS and
> > > "ADblock
> > > > > Browser" aren't.
> > > > 
> > > > I don't think that it would be possible to check all the language
specific
> > > > mistakes I do think that it's something that translators should take
care
> > > about,
> > > > because I'm pretty sure there are more inconsistency in the
translations,
> > than
> > > > just missing Android, I've noticed most of them also are translating
word
> > > > "Browser" while the description clearly says "Please don't translate
> > "Adblock
> > > > Browser", since that is our fixed product name.".
> > > 
> > > Yes, in particular translation agencies, tend to deliver inconsistent and
> bad
> > > translations. Their translators don't know the product and the context.
And
> > > therefore we need to verify their translations.
> > 
> > So I see 2 options:
> > * Check all translations with similar porblem, come back to Translators
asking
> > to fix.
> > * Push the changes and modify them afterward.
> > 
> > While I thought it's a priority project, maybe make sense to go with second
> > option ?
> 
> Well, I did check all translations for similar issues, and left comments where
I
> found something. But yeah, in the long term we really need a dedicated
> translation manager for that stuff.

@Phill don't you mind if I'll use your account and ask all the translators who
translated "Adblock" "Browser" "Andoird" or "IOS" to update their translation ?

Philip Hill

On 2015/09/11 13:56:03, saroyanm wrote: > https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstRun.json > File locale/bn-BD/firstRun.json (right): > > https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstRun.json#newcode9 > ...

Sept. 11, 2015, 1:57 p.m. (2015-09-11 13:57:26 UTC) #12

On 2015/09/11 13:56:03, saroyanm wrote:
>
https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstR...
> File locale/bn-BD/firstRun.json (right):
> 
>
https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstR...
> locale/bn-BD/firstRun.json:9: "message": "অ্যান্ড্রয়েড ও iOS-এর জন্য উপলভ্য"
> On 2015/09/11 13:48:43, Sebastian Noack wrote:
> > On 2015/09/11 13:45:13, saroyanm wrote:
> > > On 2015/09/11 13:30:03, Sebastian Noack wrote:
> > > > On 2015/09/11 12:51:25, saroyanm wrote:
> > > > > On 2015/09/11 11:53:56, Sebastian Noack wrote:
> > > > > > I doubt that Android is supposed to be translated here, while iOS
and
> > > > "ADblock
> > > > > > Browser" aren't.
> > > > > 
> > > > > I don't think that it would be possible to check all the language
> specific
> > > > > mistakes I do think that it's something that translators should take
> care
> > > > about,
> > > > > because I'm pretty sure there are more inconsistency in the
> translations,
> > > than
> > > > > just missing Android, I've noticed most of them also are translating
> word
> > > > > "Browser" while the description clearly says "Please don't translate
> > > "Adblock
> > > > > Browser", since that is our fixed product name.".
> > > > 
> > > > Yes, in particular translation agencies, tend to deliver inconsistent
and
> > bad
> > > > translations. Their translators don't know the product and the context.
> And
> > > > therefore we need to verify their translations.
> > > 
> > > So I see 2 options:
> > > * Check all translations with similar porblem, come back to Translators
> asking
> > > to fix.
> > > * Push the changes and modify them afterward.
> > > 
> > > While I thought it's a priority project, maybe make sense to go with
second
> > > option ?
> > 
> > Well, I did check all translations for similar issues, and left comments
where
> I
> > found something. But yeah, in the long term we really need a dedicated
> > translation manager for that stuff.
> 
> @Phill don't you mind if I'll use your account and ask all the translators who
> translated "Adblock" "Browser" "Andoird" or "IOS" to update their translation
?

If you have a strong feeling that we need to tackle this before the release of
this, go ahead.

Sebastian Noack

On 2015/09/11 13:57:26, Philip Hill wrote: > If you have a strong feeling that we ...

Sept. 11, 2015, 2:02 p.m. (2015-09-11 14:02:55 UTC) #14

saroyanm

Sept. 11, 2015, 2:33 p.m. (2015-09-11 14:33:57 UTC) #15

https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstR...
File locale/bn-BD/firstRun.json (right):

https://codereview.adblockplus.org/29327142/diff/29327143/locale/bn-BD/firstR...
locale/bn-BD/firstRun.json:9: "message": "অ্যান্ড্রয়েড ও iOS-এর জন্য উপলভ্য"
On 2015/09/11 13:56:02, saroyanm wrote:
> On 2015/09/11 13:48:43, Sebastian Noack wrote:
> > On 2015/09/11 13:45:13, saroyanm wrote:
> > > On 2015/09/11 13:30:03, Sebastian Noack wrote:
> > > > On 2015/09/11 12:51:25, saroyanm wrote:
> > > > > On 2015/09/11 11:53:56, Sebastian Noack wrote:
> > > > > > I doubt that Android is supposed to be translated here, while iOS
and
> > > > "ADblock
> > > > > > Browser" aren't.
> > > > > 
> > > > > I don't think that it would be possible to check all the language
> specific
> > > > > mistakes I do think that it's something that translators should take
> care
> > > > about,
> > > > > because I'm pretty sure there are more inconsistency in the
> translations,
> > > than
> > > > > just missing Android, I've noticed most of them also are translating
> word
> > > > > "Browser" while the description clearly says "Please don't translate
> > > "Adblock
> > > > > Browser", since that is our fixed product name.".
> > > > 
> > > > Yes, in particular translation agencies, tend to deliver inconsistent
and
> > bad
> > > > translations. Their translators don't know the product and the context.
> And
> > > > therefore we need to verify their translations.
> > > 
> > > So I see 2 options:
> > > * Check all translations with similar porblem, come back to Translators
> asking
> > > to fix.
> > > * Push the changes and modify them afterward.
> > > 
> > > While I thought it's a priority project, maybe make sense to go with
second
> > > option ?
> > 
> > Well, I did check all translations for similar issues, and left comments
where
> I
> > found something. But yeah, in the long term we really need a dedicated
> > translation manager for that stuff.
> 
> @Phill don't you mind if I'll use your account and ask all the translators who
> translated "Adblock" "Browser" "Andoird" or "IOS" to update their translation
?

Commented under the translations:
https://www.onehourtranslation.com/project/NJ3813225/# (Chinese Simplified:
zh-CN)
https://www.onehourtranslation.com/project/PX3813278/# (Vietnamese: vi)
https://www.onehourtranslation.com/project/YD3813277/# (Ukrainian: uk)
https://www.onehourtranslation.com/project/HM3813216/# (Albanian: sq)
https://www.onehourtranslation.com/project/EN3813256/# (Marathi: mr)
https://www.onehourtranslation.com/project/BL3813253/# (Macedonian: mk)
https://www.onehourtranslation.com/project/ZE3813239/# (Hindi: hi-IN)
https://www.onehourtranslation.com/project/WK3813238/# (Hebrew: he)
https://www.onehourtranslation.com/project/JH3813221/# (Bengali: bn-BD)
https://www.onehourtranslation.com/project/BT3813217/# (Arabic: ar)
https://www.onehourtranslation.com/project/EY3813259/# (Persian: fa)

Will update as soon they will provide the new translations.

Sebastian Noack

https://codereview.adblockplus.org/29327142/diff/29327143/locale/fr/firstRun.json File locale/fr/firstRun.json (right): https://codereview.adblockplus.org/29327142/diff/29327143/locale/fr/firstRun.json#newcode8 locale/fr/firstRun.json:8: "firstRun_abbPromotionHeadline": { On 2015/09/11 13:48:43, Sebastian Noack wrote: > ...

Sept. 11, 2015, 2:36 p.m. (2015-09-11 14:36:57 UTC) #16

saroyanm

Sept. 11, 2015, 3:01 p.m. (2015-09-11 15:01:14 UTC) #17

saroyanm

Patch Set 6 : Translation fixes provided by translators Translations are updated, only the Albanian ...

Sept. 15, 2015, 10 a.m. (2015-09-15 10:00:05 UTC) #18

tamara

Those were the few changes I could find so far and as mentioned in my ...

Sept. 16, 2015, 12:15 p.m. (2015-09-16 12:15:12 UTC) #20

saroyanm

https://codereview.adblockplus.org/29327142/diff/29327634/locale/ar/firstRun.json File locale/ar/firstRun.json (right): https://codereview.adblockplus.org/29327142/diff/29327634/locale/ar/firstRun.json#newcode15 locale/ar/firstRun.json:15: "message": "متوفر لنظامي Android و iOS" On 2015/09/16 12:15:04, ...

Sept. 16, 2015, 1:14 p.m. (2015-09-16 13:14:23 UTC) #21

Sebastian Noack

https://codereview.adblockplus.org/29327142/diff/29327634/locale/sq/firstRun.json File locale/sq/firstRun.json (right): https://codereview.adblockplus.org/29327142/diff/29327634/locale/sq/firstRun.json#newcode12 locale/sq/firstRun.json:12: "message": "Merre shfletuesin Adblock këtu" On 2015/09/16 13:14:20, saroyanm ...

Sept. 16, 2015, 1:16 p.m. (2015-09-16 13:16:34 UTC) #22

saroyanm

Sept. 16, 2015, 1:26 p.m. (2015-09-16 13:26:55 UTC) #23

tamara

On 2015/09/16 13:26:55, saroyanm wrote: > https://codereview.adblockplus.org/29327142/diff/29327634/locale/sq/firstRun.json > File locale/sq/firstRun.json (right): > > https://codereview.adblockplus.org/29327142/diff/29327634/locale/sq/firstRun.json#newcode12 > ...

Sept. 16, 2015, 1:46 p.m. (2015-09-16 13:46:46 UTC) #24

LGTM

Expand All Messages | Collapse All Messages