Issue 3024 - Added opt-out to Chrome notifications

options.js

Index: options.js
===================================================================
--- a/options.js
+++ b/options.js
@@ -108,6 +108,24 @@
 {
   if (msg.type == "add-subscription")
     startSubscriptionSelection(msg.title, msg.url);
+  else if (msg.type == "focus-section")
+  {
+    var tabs = document.getElementsByClassName("ui-tabs-panel");
+    for (var i = 0; i < tabs.length; i++)
+    {
+      var found = tabs[i].querySelector("[data-section='" + msg.section + "'");

[Sebastian Noack, 2015/09/11 10:58:26]

It seems you forgot the closing ']' in the selector.

[Thomas Greiner, 2015/09/11 12:51:48]

Done.

Apparently, both `document.querySelector("[data-section='notifications'")` and
even `document.querySelector("[data-section='notifications")` return the correct
result and don't throw an error. That explains why I didn't spot this earlier.

Not sure why it works though but it's the same behavior in both Chrome and
Firefox and it doesn't appear to be standard-compliant from what I've read. I'll
check whether this is intended behavior and report it to the respective browsers
if necessary.

[Sebastian Noack, 2015/09/11 13:09:54]

My guess would be, that some popular browser didn't mind throwing an exception,
that some websites started to rely on that behavior, that other browser vendors
adopted that behavior for compatibility. 

+      if (!found)
+        continue;
+
+      var previous = document.getElementsByClassName("focused");
+      if (previous.length > 0)
+        previous[0].classList.remove("focused");
+
+      var tab = $("[href='#" + tabs[i].id + "']");
+      $("#tabs").tabs("select", tab.parent().index());
+      found.classList.add("focused");
+    }
+  }
 };
 
 // Reloads the displayed subscriptions and filters