Unified Diff: cms/utils.py
Issue 29328208:
Noissue - [CMS] Avoid overzealous catching of KeyError during conversion (Closed)
Patch Set:
Created Sept. 21, 2015, 9:16 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: cms/utils.py |
| diff --git a/cms/utils.py b/cms/utils.py |
| index 66d8498f74582a93b1fff3ccac87879d2877654b..190410f18c7c11c61f216749cfe860bd482c346e 100644 |
| --- a/cms/utils.py |
| +++ b/cms/utils.py |
| @@ -48,9 +48,9 @@ def get_page_params(source, locale, page, format=None, site_url_override=None, |
| else: |
| params["site_url"] = params["config"].get("general", "siteurl") |
| - try: |
| + if format in converters: |
| converter = converters[format](params) |
| - except KeyError: |
| + else: |
| raise Exception("Page %s uses unknown format %s" % (page, format)) |
|
Wladimir Palant
2015/09/21 10:54:29
I think Sebastian will object to that approach :)
kzar
2015/09/21 11:06:22
Yea, I guessed it might have been unpopular. It se
|
| # Note: The converter might change some parameters so we can only read in |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
