Unified Diff: cms/utils.py
Issue 29328208:
Noissue - [CMS] Avoid overzealous catching of KeyError during conversion (Closed)
Patch Set: Gave converter_class variable a better name
Created Sept. 21, 2015, 11:20 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: cms/utils.py |
| diff --git a/cms/utils.py b/cms/utils.py |
| index 66d8498f74582a93b1fff3ccac87879d2877654b..d6cdf895151ecf792c2269630f3683e763bf326f 100644 |
| --- a/cms/utils.py |
| +++ b/cms/utils.py |
| @@ -49,10 +49,12 @@ def get_page_params(source, locale, page, format=None, site_url_override=None, |
| params["site_url"] = params["config"].get("general", "siteurl") |
| try: |
| - converter = converters[format](params) |
| + converter_class = converters[format] |
| except KeyError: |
| raise Exception("Page %s uses unknown format %s" % (page, format)) |
| + converter = converter_class(params) |
| + |
| # Note: The converter might change some parameters so we can only read in |
| # template data here. |
| params["templatedata"] = source.read_template(params["template"]) |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
