Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(936)

Issue 29328521: Issue 133 - Add README to sitescripts repository (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by kzar
Modified:
4 years, 1 month ago
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 133 - Add README to sitescripts repository

Patch Set 1 #

Total comments: 12

Patch Set 2 : Addressed feedback #

Total comments: 4

Patch Set 3 : Addressed some final nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -0 lines) Patch
A README.md View 1 2 1 chunk +83 lines, -0 lines 0 comments Download

Messages

Total messages: 8
kzar
Patch Set 1
4 years, 1 month ago (2015-09-23 10:26:21 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29328521/diff/29328522/README.md File README.md (right): https://codereview.adblockplus.org/29328521/diff/29328522/README.md#newcode25 README.md:25: 1.) ~/.sitescripts Nit: Using closing parenthesis for numbered lists ...
4 years, 1 month ago (2015-10-05 10:56:58 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29328521/diff/29328522/README.md File README.md (right): https://codereview.adblockplus.org/29328521/diff/29328522/README.md#newcode23 README.md:23: The configuration file can be placed in a number ...
4 years, 1 month ago (2015-10-05 11:22:20 UTC) #3
kzar
Patch Set 2 : Addressed feedback https://codereview.adblockplus.org/29328521/diff/29328522/README.md File README.md (right): https://codereview.adblockplus.org/29328521/diff/29328522/README.md#newcode23 README.md:23: The configuration file ...
4 years, 1 month ago (2015-10-06 13:00:13 UTC) #4
Wladimir Palant
https://codereview.adblockplus.org/29328521/diff/29328861/README.md File README.md (right): https://codereview.adblockplus.org/29328521/diff/29328861/README.md#newcode74 README.md:74: So, to test any of the URL handlers in ...
4 years, 1 month ago (2015-10-06 18:39:37 UTC) #5
kzar
Patch Set 3 : Addressed some final nits https://codereview.adblockplus.org/29328521/diff/29328861/README.md File README.md (right): https://codereview.adblockplus.org/29328521/diff/29328861/README.md#newcode74 README.md:74: So, ...
4 years, 1 month ago (2015-10-07 13:36:27 UTC) #6
Wladimir Palant
LGTM
4 years, 1 month ago (2015-10-07 15:21:21 UTC) #7
Sebastian Noack
4 years, 1 month ago (2015-10-08 08:19:11 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5