Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29328567: Issue 3116 - Document changed multi-locale build procedure (Closed)

Created:
Sept. 24, 2015, 8:47 a.m. by René Jeschke
Modified:
Sept. 24, 2015, 9:25 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Issue 3116 - Document changed multi-locale build procedure

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M README.md View 4 chunks +6 lines, -1 line 1 comment Download

Messages

Total messages: 2
René Jeschke
Sept. 24, 2015, 8:48 a.m. (2015-09-24 08:48:08 UTC) #1
Felix Dahlke
Sept. 24, 2015, 9:20 a.m. (2015-09-24 09:20:30 UTC) #2
LGTM - let's see how long we can keep the README in sync with the build
automation, first round is a win for you :)

https://codereview.adblockplus.org/29328567/diff/29328568/README.md
File README.md (right):

https://codereview.adblockplus.org/29328567/diff/29328568/README.md#newcode40
README.md:40: hg clone ssh://hg@bitbucket.org/adblockplus/mozharness -r
adblockbrowser
I think that's actually better than before, to just point to the head of the
adblockbrowser branch in mozharness here. That should always be in sync with the
adblockbrowser branch in the adblockbrowser repo, no need to update this line
anymore. The actual mapping is  in adblockbrowser-build/dependencies anyway.

Powered by Google App Engine
This is Rietveld