templates/sitekey_frame.tmpl - Issue 29328600: Issue 3122 - Add sitekey frame files ready for sitekey testcases

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: templates/sitekey_frame.tmpl

Issue 29328600: Issue 3122 - Add sitekey frame files ready for sitekey testcases (Closed)

Patch Set: Attempt to make frame URL logic clearer Created Oct. 13, 2015, 11:28 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 {% extends "frame.tmpl" %}
	saroyanm 2015/10/13 12:24:44 "TemplateNotFound: frame.tmpl" maybe -> {% extends "TemplateNotFound: frame.tmpl" maybe -> {% extends "templates/frame" %} ? kzar 2015/10/15 15:06:21 I'm not able to reproduce that problem, when exact Show quoted text On 2015/10/13 12:24:44, saroyanm wrote: > "TemplateNotFound: frame.tmpl" > maybe -> {% extends "templates/frame" %} ? I'm not able to reproduce that problem, when exactly do you hit it? (This template sitekey_frame.tmpl is designed to be rendered by the related URL handler in the sitescripts repository.) saroyanm 2015/10/15 15:38:16 Assigne this template to some page `template=sitek Show quoted text On 2015/10/15 15:06:21, kzar wrote: > On 2015/10/13 12:24:44, saroyanm wrote: > > "TemplateNotFound: frame.tmpl" > > maybe -> {% extends "templates/frame" %} ? > > I'm not able to reproduce that problem, when exactly do you hit it? (This > template sitekey_frame.tmpl is designed to be rendered by the related URL > handler in the sitescripts repository.) Assigne this template to some page `template=sitekey_frame` Ex.: change template of `pages/testcases/generic/01.md` from "testcase" to "sitekey_frame" kzar 2015/10/15 16:19:12 Ah right I see, well it's designed to be rendered Show quoted text On 2015/10/15 15:38:16, saroyanm wrote: > On 2015/10/15 15:06:21, kzar wrote: > > On 2015/10/13 12:24:44, saroyanm wrote: > > > "TemplateNotFound: frame.tmpl" > > > maybe -> {% extends "templates/frame" %} ? > > > > I'm not able to reproduce that problem, when exactly do you hit it? (This > > template sitekey_frame.tmpl is designed to be rendered by the related URL > > handler in the sitescripts repository.) > > Assigne this template to some page `template=sitekey_frame` > Ex.: change template of `pages/testcases/generic/01.md` from "testcase" to > "sitekey_frame" Ah right I see, well it's designed to be rendered by sitescripts and not used as a CMS page template. I wouldn't expect that to work. saroyanm 2015/10/15 16:23:23 But if you use -> {% extends "templates/frame" %} Show quoted text On 2015/10/15 16:19:12, kzar wrote: > On 2015/10/15 15:38:16, saroyanm wrote: > > On 2015/10/15 15:06:21, kzar wrote: > > > On 2015/10/13 12:24:44, saroyanm wrote: > > > > "TemplateNotFound: frame.tmpl" > > > > maybe -> {% extends "templates/frame" %} ? > > > > > > I'm not able to reproduce that problem, when exactly do you hit it? (This > > > template sitekey_frame.tmpl is designed to be rendered by the related URL > > > handler in the sitescripts repository.) > > > > Assigne this template to some page `template=sitekey_frame` > > Ex.: change template of `pages/testcases/generic/01.md` from "testcase" to > > "sitekey_frame" > > Ah right I see, well it's designed to be rendered by sitescripts and not used as > a CMS page template. I wouldn't expect that to work. But if you use -> {% extends "templates/frame" %} looks to work fine. kzar 2015/10/15 16:28:51 So this template is designed to be rendered by sit Show quoted text On 2015/10/15 16:23:23, saroyanm wrote: > On 2015/10/15 16:19:12, kzar wrote: > > On 2015/10/15 15:38:16, saroyanm wrote: > > > On 2015/10/15 15:06:21, kzar wrote: > > > > On 2015/10/13 12:24:44, saroyanm wrote: > > > > > "TemplateNotFound: frame.tmpl" > > > > > maybe -> {% extends "templates/frame" %} ? > > > > > > > > I'm not able to reproduce that problem, when exactly do you hit it? (This > > > > template sitekey_frame.tmpl is designed to be rendered by the related URL > > > > handler in the sitescripts repository.) > > > > > > Assigne this template to some page `template=sitekey_frame` > > > Ex.: change template of `pages/testcases/generic/01.md` from "testcase" to > > > "sitekey_frame" > > > > Ah right I see, well it's designed to be rendered by sitescripts and not used > as > > a CMS page template. I wouldn't expect that to work. > > But if you use -> {% extends "templates/frame" %} looks to work fine. So this template is designed to be rendered by sitescripts.testpages.web.sitekey_frame . If I omit the ".tmpl" extension that URL handler can no longer render the template - it breaks. This template is not designed to be used by CMS pages, it does not matter if it does not work for them.
	2

	3 {% block body %}

	4 <script type="text/javascript">

	5 function frame_url(parent_location)

	6 {

	7 return parent_location.hash.substring(1);

	8 }

	9 </script>

	10 {% endblock %}

OLD	NEW

« no previous file with comments | « templates/frame.tmpl ('k') | no next file » | no next file with comments »