Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29328694: Issue 3133 - Always perform a clobber before building (Closed)

Created:
Sept. 29, 2015, 12:42 p.m. by Felix Dahlke
Modified:
Sept. 29, 2015, 3:42 p.m.
Reviewers:
René Jeschke
Visibility:
Public.

Description

Issue 3133 - Always perform a clobber before building

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M build.py View 2 chunks +9 lines, -9 lines 2 comments Download

Messages

Total messages: 4
Felix Dahlke
Sept. 29, 2015, 12:43 p.m. (2015-09-29 12:43:06 UTC) #1
René Jeschke
LGTM https://codereview.adblockplus.org/29328694/diff/29328695/build.py File build.py (right): https://codereview.adblockplus.org/29328694/diff/29328695/build.py#newcode67 build.py:67: subprocess.check_call([os.path.join(ABB_PATH, "mach"), "clobber"], Nit: there has been an ...
Sept. 29, 2015, 3:19 p.m. (2015-09-29 15:19:41 UTC) #2
Felix Dahlke
https://codereview.adblockplus.org/29328694/diff/29328695/build.py File build.py (right): https://codereview.adblockplus.org/29328694/diff/29328695/build.py#newcode67 build.py:67: subprocess.check_call([os.path.join(ABB_PATH, "mach"), "clobber"], On 2015/09/29 15:19:41, René Jeschke wrote: ...
Sept. 29, 2015, 3:20 p.m. (2015-09-29 15:20:32 UTC) #3
René Jeschke
Sept. 29, 2015, 3:22 p.m. (2015-09-29 15:22:33 UTC) #4
On 2015/09/29 15:20:32, Felix Dahlke wrote:
> https://codereview.adblockplus.org/29328694/diff/29328695/build.py
> File build.py (right):
> 
> https://codereview.adblockplus.org/29328694/diff/29328695/build.py#newcode67
> build.py:67: subprocess.check_call([os.path.join(ABB_PATH, "mach"),
"clobber"],
> On 2015/09/29 15:19:41, René Jeschke wrote:
> > Nit: there has been an empty line here, now it's gone. Intended or accident?
> 
> Intended, but no strong opinion :P

Yeah, fine with me either way :-)

Powered by Google App Engine
This is Rietveld