Issue 2018 - Optimized first-run page for smaller screens

skin/firstRun.css

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 81 matching lines @@
   padding: 16px 0px;
   border: 1px #57ab5b;
   border-style: dashed none;
   /* border parallel fix - 957px is the value
    * closest to 960px(page width) which makes
    * the dashed border parallel
    */
   max-width: 957px;
 }
 
-h1, h2, h3
+h1,
+h2,
+h3
 {
  font-family: CreteRound, Helvetica, Arial, sans-serif;
 }
 
 h2
 {
   font-size: 26px;
   font-weight: lighter;
   color: #968d81;
   line-height: 28px;
@@ skipping 23 matching lines @@
   padding: 0;
 }
 
 section
 {
   margin: 0 auto;
   margin-bottom: 30px;
   max-width: 960px;
   background-image: url(background.png);
   padding: 40px 100px;
+  box-sizing: border-box;
 }
 
 #general
 {
   display: table;
   padding-left: 0px;
   padding-right: 0px;
 }
 
 #general > div
@@ skipping 84 matching lines @@
 #logo
 {
   margin: 0 auto;
   height: 128px;
   width: 128px;
   display: block;
 }
 
 #can-do-more
 {
-  padding: 40px 0px 0px 0px;
   border-bottom: 4px solid #968D81;
 }
 
-#can-do-more > h2
-{
-  margin: 0 100px;
-}
-
 .feature-malware-image
 {
   background-image: url(features/malware.png);
   background-repeat: no-repeat;
 }
 
 .feature-social-image
 {
   background-image: url(features/social.png);
   background-repeat: no-repeat;
 }
 
 .feature-tracking-image
 {
   background-image: url(features/tracking.png);
   background-repeat: no-repeat;
 }
 
 #can-do-more-content
 {
-  margin: 30px 100px;
+  margin-top: 30px;
 }
 
 #can-do-more #features
 {
   border-spacing: 10px;
-  margin: 0px;
-  padding: 0px;
 }
 
 #can-do-more .feature
 {
   list-style-type: none;
   padding-top: 30px;
   padding-bottom: 20px;
   border-top: 1px dashed #c0bebb;
 }
 
 #can-do-more .feature-image, #can-do-more .feature-description
 {
   display: inline-block;
-  *display: inline; /* IE6 inline-block fix */
-  *zoom: 1;
   vertical-align: top;
 }
 
 #can-do-more .feature-description
 {
   -webkit-margin-start: 20px;
   -moz-margin-start: 20px;
-  margin-start: 20px;

[Sebastian Noack, 2015/10/05 12:23:56]

It seems there isn't an unprefixed margin-start, but margin-inline-start and
margin-block-start.

https://developer.mozilla.org/en-US/docs/Web/CSS/margin-inline-start
https://developer.mozilla.org/en-US/docs/Web/CSS/margin-block-start

Same for other -start/-end properties.

[saroyanm, 2015/10/05 12:51:10]

Both are part of experimental API. Once we implemented border-inline-start-width
in this file, but didn't consider them of being experimental, so I think we need
to go with prefixed versions only, there is also discussion regarding that in
previous review for adblockplusui module:
https://codereview.adblockplus.org/29323156/diff/29328570/skin/options.css#ne...

[Thomas Greiner, 2015/10/05 13:43:17]

I did a bit of research on that since the situation is more convoluted than I
thought. Apparently, the prefixed versions of `margin-{start,end}` were dropped
judging from the 404 page on MDN
(https://developer.mozilla.org/en-US/docs/Talk%3ACSS/-moz-margin-start).

However, the `margin-{block,inline}-{start,end}` properties are currently only
supported in Firefox according to MDN and I can confirm that using those shows
the "Unknown property name" warning in Chrome's Developer Tools. Therefore it
seems that were stuck with using the prefixed versions of `margin-{start,end}`.

   width: 625px;
   max-width: 85%;
 }
 
 #can-do-more .feature-description-textblock
 {
   width: 480px;
   max-width: 100%;
   -webkit-margin-end: 40px;
   -moz-margin-end: 40px;
-  margin-end: 40px;
   display: inline-block;
 }
 
 #can-do-more .feature-description-textblock > span
 {
   margin-top: 15px;
 }
 
 #can-do-more .feature-image
 {
   width: 59px;
   height: 59px;
   margin: 10px 0px;
   -webkit-margin-start: 20px;
   -moz-margin-start: 20px;
-  margin-start: 20px;
 }
 
 #share
 {
   background-image: url(background-share.png);
-  max-width: 760px;
   text-align: center;
   font-family: CreteRound, Helvetica, Arial, sans-serif;
 }
 
 #share h2
 {
   margin-bottom: 30px;
 }
 
 #share h2,
@@ skipping 332 matching lines @@
   }
 
   #general > div,
   #can-do-more > h2,
   #can-do-more-content
   {
     margin-left: 20px;
     margin-right: 20px;
   }
   
-  #can-do-more
+  #can-do-more,
+  #can-do-more .feature h3
   {
     text-align: center;
   }
 
   #can-do-more .feature-description-textblock
   {
     text-align: start;
   }
-  
-  #can-do-more .feature h3
-  {
-    text-align: center;
-  }
 
   .toggle
   {
     margin-top: 14px;
   }
 }