Issue 2018 - Optimized first-run page for smaller screens

skin/firstRun.css

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 61 matching lines @@
   margin: 0;
   padding: 0;
   list-style-type: none;
 }
 
 header
 {
   background-image: url(background.png);
   background-repeat: repeat-x;
   width: 100%;
   padding-top: 25px;

[saroyanm, 2015/10/05 17:18:55]

Should we need to use shorthand in this case ? Have doubt, what you think
@Thomas ?

 }
 
 header h1
 {
   font-size: 24px;
   font-weight: normal;
   color: #57ab5b;
   text-align: center;
   margin: 21px auto;
   padding: 16px 0px;
   border: 1px #57ab5b;
   border-style: dashed none;
   /* border parallel fix - 957px is the value
    * closest to 960px(page width) which makes
    * the dashed border parallel
    */
   max-width: 957px;
 }
 
-h1, h2, h3

[saroyanm, 2015/10/05 17:18:55]

Nit: I think each selectors should go to it's own line in this case.

[Thomas Greiner, 2015/10/06 09:54:36]

Done.

+h1,
+h2,
+h3
 {
  font-family: CreteRound, Helvetica, Arial, sans-serif;
 }
 
 h2
 {
   font-size: 26px;
   font-weight: lighter;
   color: #968d81;
   line-height: 28px;
   text-align: center;
   margin: 0;
   padding: 0;
 }
 
 h3
 {
   font-size: 22px;
   color: #7F776B;
   font-weight: normal;
   margin-top: 0px;

[saroyanm, 2015/10/05 17:18:55]

Nit: I think you can use shorthand here.

[Thomas Greiner, 2015/10/06 09:54:36]

The problem with using shorthand properties here is that we'd override
`margin-left` and `margin-right` which could've been specified elsewhere even
though we don't really care about what values they have.

Probably makes sense to take that into consideration for #3158. Shorthand
properties make sense if they don't force you to override stuff that you don't
need to. Otherwise they may lead to duplication of values.

Example:

h3
{
  margin-left: 10px;
}

header h3
{
  /* using shorthand: incorrect */
  margin: 0px 0px 10px 0px;
  /* using shorthand: correct */
  margin: 0px 0px 10px 10px;
  /* not using shorthand */
  margin-bottom: 10px;
}

Problem: The correct shorthand requires duplication of the defined value above.

   margin-bottom: 10px;
   padding: 0;
   line-height: 24px;
 }
 
 h4
 {
   font-size: 15px;
   color: #7f776b;
   font-weight: normal;
   text-align: center;
   margin: 0;
   padding: 0;
 }
 
 section
 {
   margin: 0 auto;
   margin-bottom: 30px;
   max-width: 960px;
   background-image: url(background.png);
   padding: 40px 100px;
+  box-sizing: border-box;
 }
 
 #general
 {
   display: table;
   padding-left: 0px;

[saroyanm, 2015/10/05 17:18:55]

Nit: I think you can use shorthand here.

   padding-right: 0px;
 }
 
 #general > div
 {
   display: table-cell;
   width: 50%;
   vertical-align: top;
   padding: 0px 50px;
   border: dashed 0 #969085;
@@ skipping 78 matching lines @@
 #logo
 {
   margin: 0 auto;
   height: 128px;
   width: 128px;
   display: block;
 }
 
 #can-do-more
 {
-  padding: 40px 0px 0px 0px;
   border-bottom: 4px solid #968D81;
 }
 
-#can-do-more > h2
-{
-  margin: 0 100px;
-}
-
 .feature-malware-image
 {
   background-image: url(features/malware.png);
   background-repeat: no-repeat;
 }
 
 .feature-social-image
 {
   background-image: url(features/social.png);
   background-repeat: no-repeat;
 }
 
 .feature-tracking-image
 {
   background-image: url(features/tracking.png);
   background-repeat: no-repeat;
 }
 
 #can-do-more-content
 {
-  margin: 30px 100px;
+  margin-top: 30px;
 }
 
 #can-do-more #features
 {
   border-spacing: 10px;
-  margin: 0px;
-  padding: 0px;
 }
 
 #can-do-more .feature
 {
   list-style-type: none;
   padding-top: 30px;
   padding-bottom: 20px;
   border-top: 1px dashed #c0bebb;
 }
 
 #can-do-more .feature-image, #can-do-more .feature-description
 {
   display: inline-block;
-  *display: inline; /* IE6 inline-block fix */
-  *zoom: 1;
   vertical-align: top;
 }
 
 #can-do-more .feature-description
 {
   -webkit-margin-start: 20px;
   -moz-margin-start: 20px;
   width: 625px;
   max-width: 85%;
 }
@@ skipping 17 matching lines @@
   width: 59px;
   height: 59px;
   margin: 10px 0px;
   -webkit-margin-start: 20px;
   -moz-margin-start: 20px;
 }
 
 #share
 {
   background-image: url(background-share.png);
-  max-width: 760px;
   text-align: center;
   font-family: CreteRound, Helvetica, Arial, sans-serif;
 }
 
 #share h2
 {
   margin-bottom: 30px;
 }
 
 #share h2,
@@ skipping 187 matching lines @@
   display: table-caption;
 }
 
 .toggle
 {
   cursor: pointer;
   position: relative;
   display: inline-block;
   vertical-align: top;
   height: 22px;
   margin-top: 32px;

[saroyanm, 2015/10/05 17:18:55]

Why shorthand was removed ?

Will stop commenting about shorthand properties from here.

   margin-bottom: 7px;
   border-radius: 9999px;
   border: 1px solid #999;
   overflow: hidden;
   -moz-user-select: none;
   -webkit-user-select: none;
   user-select: none;
 }
 
 .toggle:hover
@@ skipping 124 matching lines @@
   }
 
   #general > div,
   #can-do-more > h2,
   #can-do-more-content
   {
     margin-left: 20px;
     margin-right: 20px;
   }
   
-  #can-do-more
+  #can-do-more,
+  #can-do-more .feature h3
   {
     text-align: center;
   }
 
   #can-do-more .feature-description-textblock
   {
     text-align: start;
   }
-  
-  #can-do-more .feature h3

[saroyanm, 2015/10/05 17:18:55]

can be merged with "#can-do-more"

[Thomas Greiner, 2015/10/06 09:54:36]

Done.

-  {
-    text-align: center;
-  }
 
   .toggle
   {
     margin-top: 14px;
   }
 }