Issue 3144 - Fixed: Findbar opened when trying to enter / or ' in filter settings dialog

chrome/content/ui/filters-search.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 235 matching lines @@
           return {target: event.currentTarget, name: message, data: event};
       return null;
     },
 
     addMessageListener: function(message, listener)
     {
       if (!this._messageMap.hasOwnProperty(message))
         return;
 
       if (!("_ABPHandler" in listener))
-        listener._ABPHandler = (event) => listener.receiveMessage(this._messageFromEvent(event));
+      {
+        listener._ABPHandler = (event) => {
+          if (event.type == "keypress")
+          {
+            let key = event.charCode ? String.fromCharCode(event.charCode) : null;
+            // Firefox manually triggers FAYT when ' or / is pressed
+            // so we need to capture those
+            if (key == "'" || key == "/")
+              return;
+          }

[Wladimir Palant, 2015/10/05 14:19:18]

Please see
https://codereview.adblockplus.org/29328828/diff/29328829/chrome/content/ui/f...
- I think we want a more generic check here.

+          listener.receiveMessage(this._messageFromEvent(event));
+        };
+      }
 
       E("filtersTree").addEventListener(this._messageMap[message], listener._ABPHandler, false);
     },
 
     removeMessageListener: function(message, listener)
     {
       if (this._messageMap.hasOwnProperty(message) && listener._ABPHandler)
         E("filtersTree").removeEventListener(this._messageMap[message], listener._ABPHandler, false);
     },
 
     sendAsyncMessage: function() {}
   }
 };
 
 window.addEventListener("load", function()
 {
   FilterSearch.init();
 }, false);