Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329028: Issue 3190 - Ensure /var/cache/$cms_repository being present and writable (Closed)

Created:
Oct. 9, 2015, 7:28 p.m. by mathias
Modified:
Oct. 13, 2015, 11:35 a.m.
Reviewers:
Fred
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 3190 - Ensure /var/cache/$cms_repository being present and writable

Patch Set 1 #

Total comments: 2

Patch Set 2 : Issue 3190 - Address feedback from codereview #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M modules/web/manifests/server.pp View 1 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 5
mathias
Oct. 9, 2015, 7:28 p.m. (2015-10-09 19:28:07 UTC) #1
Fred
https://codereview.adblockplus.org/29329028/diff/29329029/modules/web/manifests/server.pp File modules/web/manifests/server.pp (right): https://codereview.adblockplus.org/29329028/diff/29329029/modules/web/manifests/server.pp#newcode99 modules/web/manifests/server.pp:99: "/var/www/${vhost}", Are the variables $repository and $vhost guaranteed to ...
Oct. 12, 2015, 1:07 p.m. (2015-10-12 13:07:48 UTC) #2
mathias
https://codereview.adblockplus.org/29329028/diff/29329029/modules/web/manifests/server.pp File modules/web/manifests/server.pp (right): https://codereview.adblockplus.org/29329028/diff/29329029/modules/web/manifests/server.pp#newcode99 modules/web/manifests/server.pp:99: "/var/www/${vhost}", On 2015/10/12 13:07:48, Fred wrote: > Are the ...
Oct. 12, 2015, 1:18 p.m. (2015-10-12 13:18:37 UTC) #3
mathias
Oct. 12, 2015, 1:32 p.m. (2015-10-12 13:32:51 UTC) #4
Fred
Oct. 12, 2015, 3:41 p.m. (2015-10-12 15:41:48 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld