Issue 3191 - Move filtermaster::repo_download to a distinct file

modules/filtermaster/manifests/init.pp

 class filtermaster(
   $repos = hiera('filtermaster::repos', []),
   $repo_downloads = hiera('filtermaster::repo_downloads', {}),
 ) {
 
   Cron {
     environment => ['MAILTO=admins@adblockplus.org', 'PYTHONPATH=/opt/sitescripts'],
   }
 
   include ssh
@@ skipping 71 matching lines @@
     require => Package['openssh-server'],
     notify => Service['ssh'],
     ensure => file,
     owner => root,
     group => root,
     source => 'puppet:///modules/private/filtermaster.adblockplus.org_ssh.pub'
   }
 
   package {['p7zip-full']:}
 
-  define repo_download($alias = $title) {
-
-    exec {"fetch_${title}":
-      command => "hg clone https://hg.adblockplus.org/${title} /home/rsync/subscription/${title}",
-      path => ["/usr/bin/", "/bin/"],
-      require => Package['mercurial'],
-      user => rsync,
-      timeout => 0,
-      onlyif => "test ! -d /home/rsync/subscription/${title}"
-    }
-  }
-
   create_resources('filtermaster::repo_download', $repo_downloads)
 
-  repo_download {$repos:
+  filtermaster::repo_download {$repos:
   }
 
   cron {'update_subscription':
     ensure => present,
     command => "python -m sitescripts.subscriptions.bin.updateSubscriptionDownloads 3>&1 1>/dev/null 2>&3 | perl -pe 's/^/\"[\" . scalar localtime() . \"] \"/e' >> /tmp/subscription_errors && chmod 666 /tmp/subscription_errors 2>/dev/null",
     user => rsync,
     require => User['rsync'],
     minute => '*/10'
   }
 
@@ skipping 14 matching lines @@
       User['rsync'],
       File['/home/rsync/update_repos.sh']
     ],
     minute  => '8-58/10'
   }
 
   class {'sitescripts':
     sitescriptsini_content => template('filtermaster/sitescripts.ini.erb'),
   }
 }