Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: skin/firstRun.css

Issue 29329048: Issue 1292 - Optimized first-run page share section for smaller screens (Closed)
Patch Set: Created Oct. 12, 2015, 1:30 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « firstRun.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skin/firstRun.css
===================================================================
--- a/skin/firstRun.css
+++ b/skin/firstRun.css
@@ -155,7 +155,7 @@
padding-right: 0px;
}
-#general > div
+#general > .block
{
display: table-cell;
width: 50%;
@@ -167,7 +167,7 @@
border-inline-start-width: 1px;
}
-#general > div:first-child
+#general > .block:first-child
{
border: none;
}
@@ -364,38 +364,31 @@
border-radius: 30px;
}
-#donate-block span, #share-block span
+#share > .block
{
- margin: 10px 20px;
-}
-
-#donate-block, #share-block
-{
- min-width: 250px;
display: inline-block;
vertical-align: top;
- padding: 5px 0 5px 0;
+ width: 50%;
+ padding: 5px 0px;
border: 1px dashed #37506d;
border-style: none dashed;
}
-#donate-block
+#share > .block:last-child
{
- width: 50%;
+ width: 49%;
+ -webkit-border-start-style: none;
saroyanm 2015/11/27 18:15:06 I do remember we had discussion several times abou
Thomas Greiner 2015/12/03 15:14:51 The platforms we support are either Gecko (Firefox
+ -moz-border-start-style: none;
}
-#share-block
+#share > .block > span
{
- width: 49%;
-
- -webkit-border-start-style: none;
- -moz-border-start-style: none;
+ margin: 10px 20px;
}
.share-buttons
{
margin-top: 6px;
- cursor: pointer;
vertical-align: top;
/* because inline block creates
* space if not captured with
@@ -661,24 +654,37 @@
}
#general,
- #general > div
+ #general > .block
{
display: block;
}
- #general > div
+ #general > .block
{
width: auto;
+ margin-left: 20px;
+ margin-right: 20px;
padding: 10px 0px;
border-width: 1px 0px 0px;
}
- #general > div,
- #can-do-more > h2,
- #can-do-more-content
+ #share > .block
{
- margin-left: 20px;
- margin-right: 20px;
+ display: block;
saroyanm 2015/11/27 18:15:06 Detail: You can move this rule with selector also
Thomas Greiner 2015/12/03 15:14:51 Done.
+ width: auto;
+ padding: 20px 0px;
+ border-style: dashed none none;
+ }
+
+ #share > .block:last-child
+ {
+ width: auto;
saroyanm 2015/11/27 18:15:06 I guess you have to set this rule again because of
Thomas Greiner 2015/12/03 15:14:51 Done. You're right. Changing the regular width fro
+ }
+
+ #donate,
+ .share-buttons
+ {
+ margin-top: 10px;
}
#can-do-more,
« no previous file with comments | « firstRun.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld