Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: options.html

Issue 29329095: Issue 2747 - Added empty state for tables in options page (Closed)
Left Patch Set: Created Oct. 13, 2015, 2:24 p.m.
Right Patch Set: Created Dec. 11, 2015, 4:48 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « locale/en-US/options.json ('k') | options.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-2015 Eyeo GmbH 4 - Copyright (C) 2006-2015 Eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 </div> 183 </div>
184 <ul id="whitelisting-table" class="table list"> 184 <ul id="whitelisting-table" class="table list">
185 <template> 185 <template>
186 <button class="delete control"></button> 186 <button class="delete control"></button>
187 <span class="display"></span> 187 <span class="display"></span>
188 </template> 188 </template>
189 </ul> 189 </ul>
190 <div class="controls"> 190 <div class="controls">
191 <button data-action="edit-domain-exception"> 191 <button data-action="edit-domain-exception">
192 <span class="icon icon-add"></span> 192 <span class="icon icon-add"></span>
193 <span>Test</span> 193 <span class="i18n_options_whitelisted_add"></span>
saroyanm 2015/11/30 11:24:21 Please change Test to "Add website", also be sure
Thomas Greiner 2015/12/11 16:49:35 Done. Must've forgotten to replace the placeholder
194 </button> 194 </button>
195 <div> 195 <div>
196 <span class="icon icon-add" data-action="add-domain-exceptio n"></span> 196 <span class="icon icon-add" data-action="add-domain-exceptio n"></span>
197 <input type="text" id="whitelisting-textbox" placeholder="ww w.example.com" /> 197 <input type="text" id="whitelisting-textbox" placeholder="ww w.example.com" />
198 <span class="icon icon-enter" data-action="add-domain-except ion"></span> 198 <span class="icon icon-enter" data-action="add-domain-except ion"></span>
199 </div> 199 </div>
200 <div> 200 <div>
201 <button id="whitelisting-add-button" class="button-add" data -action="add-domain-exception"> 201 <button id="whitelisting-add-button" class="button-add" data -action="add-domain-exception">
202 +<span class="i18n_options_button_add"></span> 202 +<span class="i18n_options_button_add"></span>
203 </button> 203 </button>
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 <div class="url"></div> 360 <div class="url"></div>
361 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> 361 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button>
362 </div> 362 </div>
363 </div> 363 </div>
364 </div> 364 </div>
365 <!-- Placeholder element to determine when to wrap focus around --> 365 <!-- Placeholder element to determine when to wrap focus around -->
366 <span class="focus-last" tabindex="0"></span> 366 <span class="focus-last" tabindex="0"></span>
367 </div> 367 </div>
368 </body> 368 </body>
369 </html> 369 </html>
LEFTRIGHT

Powered by Google App Engine
This is Rietveld