Issue 3210 - Don`t fall back to our downloads for Firefox extensions

sitescripts/extensions/utils.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2015 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 314 matching lines @@
     if not highestVersion or compareVersions(version, highestVersion) > 0:
       highestURL = urlparse.urljoin(repo.downloadsURL, filename)
       highestVersion = version
 
   return (highestURL, highestVersion)
 
 def _getDownloadLink(repo):
   """
   gets the download link to the most current version of an extension
   """
-  # you can't easily install extensions from third-party sources on Chrome
-  # and Opera. So always get the link for the version on the Web Store.
   if repo.galleryID:
     if repo.type == "chrome":
       return _getGoogleDownloadLink(repo.galleryID)
-    if repo.type == "opera":
+    elif repo.type == "opera":
       return _getOperaDownloadLink(repo.galleryID)
+    elif repo.type == "gecko":
+      return _getMozillaDownloadLink(repo.galleryID)
 
-  (localURL, localVersion) = _getLocalLink(repo)
-
-  # get a link to Firefox Add-Ons, if the latest version has been published there
-  if repo.type == 'gecko' and repo.galleryID:
-    (galleryURL, galleryVersion) = _getMozillaDownloadLink(repo.galleryID)
-    if not localVersion or (galleryVersion and
-                            compareVersions(galleryVersion, localVersion) >= 0):
-      return (galleryURL, galleryVersion)
-
-  return (localURL, localVersion)
+  return _getLocalLink(repo)
 
 def _getQRCode(text):
   try:
     import qrcode
     import base64
     import Image    # required by qrcode but not formally a dependency
   except:
     return None
 
   data = StringIO()
@@ skipping 62 matching lines @@
   if not extensions:
     return
 
   updates = {}
   for extension in extensions:
     updates[extension['basename']] = {
       "url": extension['updateURL'],
       "version": extension['version']
     }
   writeLibabpUpdateManifest(path, updates)