Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329302: Issue 2972 - Properly generate Git ignore paths for dependencies (Closed)

Created:
Oct. 20, 2015, 9:07 p.m. by kzar
Modified:
Oct. 20, 2015, 9:49 p.m.
Reviewers:
Sebastian Noack
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 2972 - Properly generate Git ignore paths for dependencies

Patch Set 1 #

Patch Set 2 : Just use + operator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ensure_dependencies.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
kzar
Patch Set 1
Oct. 20, 2015, 9:07 p.m. (2015-10-20 21:07:57 UTC) #1
Sebastian Noack
Why don't you simply use the + operator instead os.path.join?
Oct. 20, 2015, 9:20 p.m. (2015-10-20 21:20:54 UTC) #2
kzar
On 2015/10/20 21:20:54, Sebastian Noack wrote: > Why don't you simply use the + operator ...
Oct. 20, 2015, 9:22 p.m. (2015-10-20 21:22:25 UTC) #3
Sebastian Noack
Wouldn't relpath() already normalize the path?
Oct. 20, 2015, 9:29 p.m. (2015-10-20 21:29:41 UTC) #4
kzar
Patch Set 2 : Just use + operator Yea, I just worried about the situation ...
Oct. 20, 2015, 9:42 p.m. (2015-10-20 21:42:36 UTC) #5
Sebastian Noack
Oct. 20, 2015, 9:44 p.m. (2015-10-20 21:44:54 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld