modules/sitescripts/manifests/keep_alive_services.pp - Issue 29329307: Issue 3211 - Integrate customservice::supervisor with notification daemon

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: modules/sitescripts/manifests/keep_alive_services.pp

Issue 29329307: Issue 3211 - Integrate customservice::supervisor with notification daemon (Closed)

Patch Set: Created Oct. 20, 2015, 10:49 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

« hiera/roles/filterserver.yaml ('K') | « hiera/roles/filterserver.yaml ('k') | modules/sitescripts/templates/keep_alive_services.erb » ('j') | modules/sitescripts/templates/keep_alive_services.erb » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # == Class: sitescripts::keep_alive_services

	2 #

	3 # Periodically check for and revive dead service instances.

	4 #

	5 class sitescripts::keep_alive_services {
	Wladimir Palant 2015/10/21 11:05:26 I don't think that this belongs in the sitescripts I don't think that this belongs in the sitescripts module - we use that module to ensure that sitescripts are set up, these scripts aren't being used here. There should be a new keepalive module or something like that. mathias 2015/10/21 11:44:01 I believe that a separation is not necessary: It i Show quoted text On 2015/10/21 11:05:26, Wladimir Palant wrote: > I don't think that this belongs in the sitescripts module - we use that module > to ensure that sitescripts are set up, these scripts aren't being used here. > There should be a new keepalive module or something like that. I believe that a separation is not necessary: It is quite normal that a Puppet module handles both the installation of a software or package, while sub-modules handle the setup of features contained within. From infrastructure perspective, I do not see any reason why this should not apply to sitescripts just as it applies to 3rd party software. However, that consideration of course heavily depends on the currently proposed approach itself. Wladimir Palant 2015/10/21 12:07:06 That's not how we use sitescripts, and it really i Show quoted text On 2015/10/21 11:44:01, mathias wrote: > I believe that a separation is not necessary: It is quite normal that a Puppet > module handles both the installation of a software or package, while sub-modules > handle the setup of features contained within. That's not how we use sitescripts, and it really isn't a package - it's rather a collection of fairly unrelated scripts used for all kinds of things. Concentrating all invocations in the sitescripts module will only make things unnecessarily complicated.
	6

	7 sitescripts::configfragment {'keep_alive_services':

	8 content => template('sitescripts/keep_alive_services.erb'),

	9 }

	10

	11 cron {'sitescripts::keep_alive_services':

	12 command => 'python -m sitescripts.management.bin.start_services',

	13 environment => concat(hiera('cron::environment', []), [

	14 'PYTHONPATH=/opt/sitescripts',

	15 ]),

	16 require => Sitescripts::Configfragment['keep_alive_services'],

	17 }

	18 }

OLD	NEW