Issue 3211 - Integrate customservice::supervisor with notification daemon

modules/sitescripts/manifests/keep_alive_services.pp

Index: modules/sitescripts/manifests/keep_alive_services.pp
diff --git a/modules/sitescripts/manifests/keep_alive_services.pp b/modules/sitescripts/manifests/keep_alive_services.pp
new file mode 100644
index 0000000000000000000000000000000000000000..fa7fda92a28aa5ce20d6f10c1c76066d52ff9168
--- /dev/null
+++ b/modules/sitescripts/manifests/keep_alive_services.pp
@@ -0,0 +1,18 @@
+# == Class: sitescripts::keep_alive_services
+#
+# Periodically check for and revive dead service instances.
+#
+class sitescripts::keep_alive_services {

[Wladimir Palant, 2015/10/21 11:05:26]

I don't think that this belongs in the sitescripts module - we use that module
to ensure that sitescripts are set up, these scripts aren't being used here.
There should be a new keepalive module or something like that.

[mathias, 2015/10/21 11:44:01]

I believe that a separation is not necessary: It is quite normal that a Puppet
module handles both the installation of a software or package, while sub-modules
handle the setup of features contained within. From infrastructure perspective,
I do not see any reason why this should not apply to sitescripts just as it
applies to 3rd party software.

However, that consideration of course heavily depends on the currently proposed
approach itself.

[Wladimir Palant, 2015/10/21 12:07:06]

That's not how we use sitescripts, and it really isn't a package - it's rather a
collection of fairly unrelated scripts used for all kinds of things.
Concentrating all invocations in the sitescripts module will only make things
unnecessarily complicated.

+
+  sitescripts::configfragment {'keep_alive_services':
+    content => template('sitescripts/keep_alive_services.erb'),
+  }
+
+  cron {'sitescripts::keep_alive_services':
+    command => 'python -m sitescripts.management.bin.start_services',
+    environment => concat(hiera('cron::environment', []), [
+      'PYTHONPATH=/opt/sitescripts',
+    ]),
+    require => Sitescripts::Configfragment['keep_alive_services'],
+  }
+}