Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329450: Issue 3208 - Don`t use numerical content types outside nsIContentPolicy.shouldLoad (Closed)

Created:
Oct. 28, 2015, 2:42 p.m. by Wladimir Palant
Modified:
Dec. 2, 2015, 12:06 p.m.
Visibility:
Public.

Description

Content policy and pop-up blocker tests pass with that change, blockable items work correctly.

Patch Set 1 #

Patch Set 2 : #

Total comments: 12

Patch Set 3 : Removed unrelated change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -117 lines) Patch
M chrome/content/ui/composer.js View 2 2 chunks +7 lines, -16 lines 0 comments Download
M lib/contentPolicy.js View 1 2 9 chunks +52 lines, -92 lines 0 comments Download
M lib/elemHide.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/objectTabs.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/requestNotifier.js View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M lib/ui.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
Wladimir Palant
Oct. 28, 2015, 2:42 p.m. (2015-10-28 14:42:59 UTC) #1
Wladimir Palant
Uploaded new patchset which removes TYPE_POPUP and TYPE_ELEMHIDE constants - these aren't actually being used ...
Oct. 29, 2015, 12:26 p.m. (2015-10-29 12:26:36 UTC) #2
Thomas Greiner
https://codereview.adblockplus.org/29329450/diff/29329460/chrome/content/ui/composer.js File chrome/content/ui/composer.js (right): https://codereview.adblockplus.org/29329450/diff/29329460/chrome/content/ui/composer.js#newcode20 chrome/content/ui/composer.js:20: var advancedMode = false; How is this change related ...
Nov. 2, 2015, 6:54 p.m. (2015-11-02 18:54:37 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29329450/diff/29329460/chrome/content/ui/composer.js File chrome/content/ui/composer.js (right): https://codereview.adblockplus.org/29329450/diff/29329460/chrome/content/ui/composer.js#newcode20 chrome/content/ui/composer.js:20: var advancedMode = false; On 2015/11/02 18:54:36, Thomas Greiner ...
Nov. 3, 2015, 11:26 a.m. (2015-11-03 11:26:49 UTC) #4
Thomas Greiner
LGTM https://codereview.adblockplus.org/29329450/diff/29329460/chrome/content/ui/composer.js File chrome/content/ui/composer.js (right): https://codereview.adblockplus.org/29329450/diff/29329460/chrome/content/ui/composer.js#newcode20 chrome/content/ui/composer.js:20: var advancedMode = false; On 2015/11/03 11:26:49, Wladimir ...
Nov. 3, 2015, 11:54 a.m. (2015-11-03 11:54:54 UTC) #5
Wladimir Palant
Nov. 4, 2015, 9:30 a.m. (2015-11-04 09:30:42 UTC) #6
https://codereview.adblockplus.org/29329450/diff/29329460/chrome/content/ui/c...
File chrome/content/ui/composer.js (right):

https://codereview.adblockplus.org/29329450/diff/29329460/chrome/content/ui/c...
chrome/content/ui/composer.js:20: var advancedMode = false;
On 2015/11/03 11:54:54, Thomas Greiner wrote:
> I see. In that case fine to fix it separately.

Ok, I removed that change here and created
https://issues.adblockplus.org/ticket/3263. All the other "changes" displayed by
the interdiff are due to rebasing.

Powered by Google App Engine
This is Rietveld