Issue #1186 - Style conformity for names in installer tests

installer/src/installer-lib/test/test-installer-lib-sandbox.cpp

 /**
  * \file test-installer-lib-sandbox.cpp
  *
  * Automatic testing of many of the units within the custom action is infeasible.
  * In one case, they rely on the execution environment within an installation session.
  * In another, they rely on the operation system environment as a whole.
  * In these cases, it's easier to verify behavior manually.
  *
  * This file contains a custom action function sandbox() as well as a number of test functions.
  * At any given time, not all of the test functions need to be referenced within the body of custom action.
@@ skipping 31 matching lines @@
 };
 
 void LogAllWindowHandles(ImmediateSession& session)
 {
   session.Log("LogAllWindowHandles");
   LogSingleWindowHandle lp(session);
   EnumerateWindows(lp);
 }
 
 //-------------------------------------------------------
-// LogIEWindowHandles
+// LogIeWindowHandles
 //-------------------------------------------------------
-class LogSingleWindowHandleOnlyIfIE

[Oleksandr, 2015/10/29 23:26:22]

Nit: LogSingleWindowHandleOnlyIfIe

[Eric, 2015/11/14 18:01:07]

Done.

+class LogSingleWindowHandleOnlyIfIe
 {
   ImmediateSession& session;
 
   ProcessCloser& pc;
 
 public:
-  LogSingleWindowHandleOnlyIfIE(ImmediateSession& session, ProcessCloser& pc)
+  LogSingleWindowHandleOnlyIfIe(ImmediateSession& session, ProcessCloser& pc)
     : session(session), pc(pc)
   {
   }
 
   bool operator()(HWND window)
   {
     DWORD pid = CreatorProcess(window);
     if (pc.Contains(pid))
     {
       std::stringstream s;
       s << "Window handle 0x" << std::hex << window;
       session.Log(s.str());
     }
     return true;
   }
 };
 
-void LogIEWindowHandles(ImmediateSession& session)
+void LogIeWindowHandles(ImmediateSession& session)
 {
-  session.Log("LogIEWindowHandles");
-  const wchar_t* IENames[] = {L"IExplore.exe", L"AdblockPlusEngine.exe"};

[Oleksandr, 2015/10/29 23:26:22]

Nit: IeNames?

[Eric, 2015/11/14 18:01:07]

Done.

+  session.Log("LogIeWindowHandles");
+  const wchar_t* IeNames[] = {L"IExplore.exe", L"AdblockPlusEngine.exe"};
   ProcessSnapshot snapshot;
-  ProcessCloser iec(snapshot, IENames);
-  LogSingleWindowHandleOnlyIfIE lp(session, iec);
+  ProcessCloser iec(snapshot, IeNames);
+  LogSingleWindowHandleOnlyIfIe lp(session, iec);
   EnumerateWindows(lp);
 }
 
 //-------------------------------------------------------
 // LogOnlyWindowHandleInCloser
 //-------------------------------------------------------
 void LogOnlyWindowHandleInCloser(ImmediateSession& session)
 {
   session.Log("LogOnlyWindowHandleInCloser");
-  const wchar_t* IENames[] = {L"IExplore.exe", L"AdblockPlusEngine.exe"};
+  const wchar_t* IeNames[] = {L"IExplore.exe", L"AdblockPlusEngine.exe"};
   ProcessSnapshot snapshot;
-  ProcessCloser iec(snapshot, IENames);
+  ProcessCloser iec(snapshot, IeNames);
   iec.IterateOurWindows(LogSingleWindowHandle(session));
 }
 
 //-------------------------------------------------------
 // sandbox
 //-------------------------------------------------------
 /**
  * Exposed DLL entry point for custom action.
  * The function signature matches the calling convention used by Windows Installer.
 
@@ skipping 22 matching lines @@
     return ERROR_INSTALL_FAILURE;
   }
   catch (...)
   {
     session.LogNoexcept("Caught an exception");
     return ERROR_INSTALL_FAILURE;
   }
 
   return ERROR_SUCCESS;
 }