Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329589: Issue 3238 - Adblock Warning List opt in message should not be triggered by frames (Chrome) (Closed)

Created:
Nov. 2, 2015, 11:25 a.m. by Wladimir Palant
Modified:
Nov. 2, 2015, 12:31 p.m.
Reviewers:
Thomas Greiner
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue 3238 - Adblock Warning List opt in message should not be triggered by frames (Chrome)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M background.js View 2 chunks +2 lines, -0 lines 0 comments Download
M webrequest.js View 3 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Nov. 2, 2015, 11:25 a.m. (2015-11-02 11:25:56 UTC) #1
Wladimir Palant
Forgot to add Sebastian to Cc, done that now.
Nov. 2, 2015, 11:26 a.m. (2015-11-02 11:26:51 UTC) #2
Thomas Greiner
Nov. 2, 2015, 12:29 p.m. (2015-11-02 12:29:33 UTC) #3
LGTM

Note that with this change the notification no longer gets triggered for
subframes. However, that behavior should be fine for most cases.

Powered by Google App Engine
This is Rietveld