Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(239)

Issue 29329589: Issue 3238 - Adblock Warning List opt in message should not be triggered by frames (Chrome) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by Wladimir Palant
Modified:
3 years, 10 months ago
Reviewers:
Thomas Greiner
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue 3238 - Adblock Warning List opt in message should not be triggered by frames (Chrome)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M background.js View 2 chunks +2 lines, -0 lines 0 comments Download
M webrequest.js View 3 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
3 years, 10 months ago (2015-11-02 11:25:56 UTC) #1
Wladimir Palant
Forgot to add Sebastian to Cc, done that now.
3 years, 10 months ago (2015-11-02 11:26:51 UTC) #2
Thomas Greiner
3 years, 10 months ago (2015-11-02 12:29:33 UTC) #3
LGTM

Note that with this change the notification no longer gets triggered for
subframes. However, that behavior should be fine for most cases.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5