Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329604: Issue 3254 - Anti-adblock warning should not show when Adblock Plus is disabled (Closed)

Created:
Nov. 2, 2015, 11:54 a.m. by Wladimir Palant
Modified:
Nov. 2, 2015, 2:36 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 3254 - Anti-adblock warning should not show when Adblock Plus is disabled

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M lib/notification.js View 1 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Nov. 2, 2015, 11:54 a.m. (2015-11-02 11:54:37 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29329604/diff/29329605/lib/notification.js File lib/notification.js (right): https://codereview.adblockplus.org/29329604/diff/29329605/lib/notification.js#newcode230 lib/notification.js:230: if (!matcher.matchesAny(url, RegExpFilter.typeMap.DOCUMENT, null, false, null)) Any reason why ...
Nov. 2, 2015, 1:59 p.m. (2015-11-02 13:59:38 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29329604/diff/29329605/lib/notification.js File lib/notification.js (right): https://codereview.adblockplus.org/29329604/diff/29329605/lib/notification.js#newcode230 lib/notification.js:230: if (!matcher.matchesAny(url, RegExpFilter.typeMap.DOCUMENT, null, false, null)) On 2015/11/02 13:59:38, ...
Nov. 2, 2015, 2:10 p.m. (2015-11-02 14:10:31 UTC) #3
Thomas Greiner
Nov. 2, 2015, 2:15 p.m. (2015-11-02 14:15:33 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld