Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(277)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
29329630
: Issue 3222 - Remove ancient dead code (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by
Wladimir Palant
Modified:
4 years, 1 month ago
Reviewers:
tschuster
,
Thomas Greiner
Visibility:
Public.
More Reviews
Description
This code used to make sense originally, location was being passed to the filters dialog. Now that no longer happens, and the code is broken anyway.
Patch Set 1
#
Created:
4 years, 1 month ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+0 lines, -3 lines
)
Patch
M
chrome/content/ui/sidebar.js
View
1 chunk
+0 lines, -3 lines
0 comments
Download
Messages
Total messages: 2
Expand All Messages
|
Collapse All Messages
Wladimir Palant
4 years, 1 month ago (2015-11-02 15:00:20 UTC)
#1
Sign in
to reply to this message.
tschuster
On 2015/11/02 15:00:20, Wladimir Palant wrote: Hehe LGTM
4 years, 1 month ago (2015-11-02 20:58:29 UTC)
#2
On 2015/11/02 15:00:20, Wladimir Palant wrote: Hehe LGTM
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 29329630: Issue 3222 - Remove ancient dead code (Closed)
Created 4 years, 1 month ago by Wladimir Palant
Modified 4 years, 1 month ago
Reviewers: Thomas Greiner, tschuster
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
87257f5