Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(286)

Issue 29329654: Issue 3222 - Split up requestNotifier module into a parent and child part (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by Wladimir Palant
Modified:
4 years ago
Visibility:
Public.

Description

This only splits up the RequestNotifier class so that blockable items list can work (after adjusting constructor parameters - outerWindowID instead of window). RequestNotifier.getWindowStatistics() and RequstNotifier.getDataForNode() are still broken, these will aren`t used by blockable items and will be fixed in other issues. RequestNotifier.storeSelection() on the other hand works just fine via wrappers - I`ll file a follow-up issue on adjusting this one for E10S but priority is lower here.

Patch Set 1 #

Patch Set 2 : Don't store outerWindowID #

Total comments: 6

Patch Set 3 : Improved comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -253 lines) Patch
M lib/child/contentPolicy.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/child/requestNotifier.js View 1 2 3 chunks +48 lines, -116 lines 0 comments Download
M lib/requestNotifier.js View 1 2 chunks +39 lines, -136 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
4 years, 1 month ago (2015-11-02 19:48:43 UTC) #1
tschuster
On 2015/11/02 19:48:43, Wladimir Palant wrote: LGTM
4 years ago (2015-11-07 12:38:57 UTC) #2
Thomas Greiner
https://codereview.adblockplus.org/29329654/diff/29329659/lib/child/requestNotifier.js File lib/child/requestNotifier.js (right): https://codereview.adblockplus.org/29329654/diff/29329659/lib/child/requestNotifier.js#newcode63 lib/child/requestNotifier.js:63: * @param {Integer} id Parent notifier ID to be ...
4 years ago (2015-11-12 12:24:06 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29329654/diff/29329659/lib/child/requestNotifier.js File lib/child/requestNotifier.js (right): https://codereview.adblockplus.org/29329654/diff/29329659/lib/child/requestNotifier.js#newcode63 lib/child/requestNotifier.js:63: * @param {Integer} id Parent notifier ID to be ...
4 years ago (2015-11-12 12:40:57 UTC) #4
Thomas Greiner
4 years ago (2015-11-12 14:15:57 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5