Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329669: Issue 3261 - Introduce module adblockplus::telemetry (Closed)

Created:
Nov. 3, 2015, 4:46 a.m. by mathias
Modified:
Nov. 16, 2015, 10:32 a.m.
Reviewers:
Fred, Felix Dahlke
Visibility:
Public.

Description

Note that it may be worth integrating with some static web::server repository at some point, or redirecting to an adblockplus.org/$path, instead of displaying the welcome-to-nginx page by default. That would also allow to display some static default content when a data submission has succeeded.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Issue 3261 - Fix adblockplus::telemetry documentation typos #

Patch Set 3 : Issue 3261 - Rename /submit/{filter-hit-statistics => adblockplus} #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -0 lines) Patch
A hiera/roles/telemetryserver.yaml View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A modules/adblockplus/manifests/telemetry.pp View 1 1 chunk +62 lines, -0 lines 0 comments Download
A modules/adblockplus/manifests/telemetry/endpoint.pp View 1 chunk +53 lines, -0 lines 0 comments Download
A modules/adblockplus/templates/telemetry/endpoint.conf.erb View 1 chunk +6 lines, -0 lines 0 comments Download
A modules/adblockplus/templates/telemetry/logrotate.erb View 1 chunk +9 lines, -0 lines 0 comments Download
M modules/private-stub/hiera/hosts.yaml View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12
mathias
Nov. 3, 2015, 4:46 a.m. (2015-11-03 04:46:55 UTC) #1
mathias
https://codereview.adblockplus.org/29329669/diff/29329670/hiera/roles/telemetryserver.yaml File hiera/roles/telemetryserver.yaml (right): https://codereview.adblockplus.org/29329669/diff/29329670/hiera/roles/telemetryserver.yaml#newcode7 hiera/roles/telemetryserver.yaml:7: location: /submit/filter-hit-statistics Note that this location conflicts with the ...
Nov. 3, 2015, 10:34 a.m. (2015-11-03 10:34:53 UTC) #2
Fred
LGTM https://codereview.adblockplus.org/29329669/diff/29329670/modules/adblockplus/manifests/telemetry.pp File modules/adblockplus/manifests/telemetry.pp (right): https://codereview.adblockplus.org/29329669/diff/29329670/modules/adblockplus/manifests/telemetry.pp#newcode12 modules/adblockplus/manifests/telemetry.pp:12: # A hash of adblockplus::telemetry::endpoin setup parameters to ...
Nov. 5, 2015, 1:59 p.m. (2015-11-05 13:59:48 UTC) #3
Felix Dahlke
https://codereview.adblockplus.org/29329669/diff/29329670/hiera/roles/telemetryserver.yaml File hiera/roles/telemetryserver.yaml (right): https://codereview.adblockplus.org/29329669/diff/29329670/hiera/roles/telemetryserver.yaml#newcode7 hiera/roles/telemetryserver.yaml:7: location: /submit/filter-hit-statistics On 2015/11/03 10:34:53, mathias wrote: > > ...
Nov. 10, 2015, 3:29 p.m. (2015-11-10 15:29:14 UTC) #4
mathias
On 2015/11/10 15:29:14, Felix Dahlke wrote: > Well, feedback and telemetry are quite different things, ...
Nov. 10, 2015, 3:33 p.m. (2015-11-10 15:33:00 UTC) #5
mathias
Nov. 11, 2015, 6:15 p.m. (2015-11-11 18:15:53 UTC) #6
Felix Dahlke
On 2015/11/10 15:33:00, mathias wrote: > On 2015/11/10 15:29:14, Felix Dahlke wrote: > > Well, ...
Nov. 12, 2015, 7:07 a.m. (2015-11-12 07:07:37 UTC) #7
mathias
On 2015/11/12 07:07:37, Felix Dahlke wrote: > I really don't think we should be making ...
Nov. 12, 2015, 10:53 a.m. (2015-11-12 10:53:41 UTC) #8
Felix Dahlke
On 2015/11/12 10:53:41, mathias wrote: > On 2015/11/12 07:07:37, Felix Dahlke wrote: > > I ...
Nov. 13, 2015, 7:38 a.m. (2015-11-13 07:38:17 UTC) #9
mathias
On 2015/11/13 07:38:17, Felix Dahlke wrote: > Well, it's true that the data for our ...
Nov. 13, 2015, 9:23 a.m. (2015-11-13 09:23:38 UTC) #10
mathias
Nov. 13, 2015, 9:29 a.m. (2015-11-13 09:29:17 UTC) #11
Felix Dahlke
Nov. 13, 2015, 12:30 p.m. (2015-11-13 12:30:57 UTC) #12
LGTM

Powered by Google App Engine
This is Rietveld