Issue 2396 - Add CSS property filter message responder

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 (function(global)
 {
   if (!global.ext)
     global.ext = require("ext_background");
 
   var Prefs = require("prefs").Prefs;
   var Utils = require("utils").Utils;
   var FilterStorage = require("filterStorage").FilterStorage;
   var FilterNotifier = require("filterNotifier").FilterNotifier;
   var defaultMatcher = require("matcher").defaultMatcher;
-  
+  var CSSRules = require("cssRules").CSSRules;
+
   var filterClasses = require("filterClasses");
   var Filter = filterClasses.Filter;
   var BlockingFilter = filterClasses.BlockingFilter;
+  var RegExpFilter = filterClasses.RegExpFilter;
   var Synchronizer = require("synchronizer").Synchronizer;
 
   var subscriptionClasses = require("subscriptionClasses");
   var Subscription = subscriptionClasses.Subscription;
   var DownloadableSubscription = subscriptionClasses.DownloadableSubscription;
   var SpecialSubscription = subscriptionClasses.SpecialSubscription;
 
   function convertObject(keys, obj)
   {
     var result = {};
@@ skipping 145 matching lines @@
           sendMessage("app", "error", [result.error.toString()], sender.page);
         else if (result.filter)
           FilterStorage.addFilter(result.filter);
         break;
       case "filters.blocked":
         var filter = defaultMatcher.matchesAny(message.url, message.requestType,
           message.docDomain, message.thirdParty);
         callback(filter instanceof BlockingFilter);
         break;
       case "filters.get":
+        if (message.what == "cssproperties")
+        {
+          var filters = [];
+          var isFrameWhitelisted = require("whitelisting").isFrameWhitelisted;
+
+          if (message.domain &&
+              !isFrameWhitelisted(sender.page, sender.frame,
+                                  RegExpFilter.typeMap.DOCUMENT |
+                                  RegExpFilter.typeMap.ELEMHIDE))

[Wladimir Palant, 2015/11/05 13:02:13]

This is going to be rather problematic in Firefox. sender.frame isn't currently
being set, and the whitelisting module doesn't exist. But given the current
direction of Firefox development I guess that the best solution will be to
provide this functionality (or something similar).

[kzar, 2015/11/05 15:51:04]

Acknowledged.

+          {
+            var specificOnly = isFrameWhitelisted(
+              sender.page, sender.frame, RegExpFilter.typeMap.GENERICHIDE
+            );

[Wladimir Palant, 2015/11/05 13:02:13]

This check makes no sense, CSS property rules are always "specific only." This
definitely needs to be fixed in the container so I would just omit the
specificOnly parameter here.

[kzar, 2015/11/05 15:51:04]

Done.

+            filters = CSSRules.getRulesForDomain(message.domain, specificOnly);
+            filters = filters.map(function(filter)
+            {
+              return {
+                prefix: filter.selectorPrefix,
+                suffix: filter.selectorSuffix,
+                regexp: filter.regexpString
+              };
+            });
+          }
+          callback(filters);
+          break;
+        }
+
         var subscription = Subscription.fromURL(message.subscriptionUrl);
         if (!subscription)
         {
           callback([]);
           break;
         }
-        
+
         callback(subscription.filters.map(convertFilter));
         break;
       case "filters.importRaw":
         var result = require("filterValidation").parseFilters(message.text);
         var errors = [];
         for (var i = 0; i < result.errors.length; i++)
         {
           var error = result.errors[i];
           if (error.type != "unexpected-filter-list-header")
             errors.push(error.toString());
@@ skipping 102 matching lines @@
           subscription.title = message.title;
           subscription.homepage = message.homepage;
           FilterStorage.addSubscription(subscription);
           if (!subscription.lastDownload)
             Synchronizer.execute(subscription);
         }
         break;
     }
   });
 })(this);