Issue 2396 - Add CSS property filter message responder

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 183 matching lines @@
         var filter = defaultMatcher.matchesAny(message.url, message.requestType,
           message.docDomain, message.thirdParty);
         callback(filter instanceof BlockingFilter);
         break;
       case "filters.get":
         if (message.what == "cssproperties")
         {
           var filters = [];
           var isFrameWhitelisted = require("whitelisting").isFrameWhitelisted;
 
-          if (message.domain &&
-              !isFrameWhitelisted(sender.page, sender.frame,
+          if (!isFrameWhitelisted(sender.page, sender.frame,
                                   RegExpFilter.typeMap.DOCUMENT |
                                   RegExpFilter.typeMap.ELEMHIDE))

[Wladimir Palant, 2015/11/05 13:02:13]

This is going to be rather problematic in Firefox. sender.frame isn't currently
being set, and the whitelisting module doesn't exist. But given the current
direction of Firefox development I guess that the best solution will be to
provide this functionality (or something similar).

[kzar, 2015/11/05 15:51:04]

Acknowledged.

           {
-            var specificOnly = isFrameWhitelisted(
-              sender.page, sender.frame, RegExpFilter.typeMap.GENERICHIDE
-            );

[Wladimir Palant, 2015/11/05 13:02:13]

This check makes no sense, CSS property rules are always "specific only." This
definitely needs to be fixed in the container so I would just omit the
specificOnly parameter here.

[kzar, 2015/11/05 15:51:04]

Done.

-            filters = CSSRules.getRulesForDomain(message.domain, specificOnly);
+            filters = CSSRules.getRulesForDomain(sender.frame.url.hostname);
             filters = filters.map(function(filter)
             {
               return {
                 prefix: filter.selectorPrefix,
                 suffix: filter.selectorSuffix,
                 regexp: filter.regexpString
               };
             });
           }
           callback(filters);
@@ skipping 122 matching lines @@
           subscription.title = message.title;
           subscription.homepage = message.homepage;
           FilterStorage.addSubscription(subscription);
           if (!subscription.lastDownload)
             Synchronizer.execute(subscription);
         }
         break;
     }
   });
 })(this);