Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329848: Issue 3129/3144 - Don`t let the findbar intercept keyboard events when editing filters (Closed)

Created:
Nov. 6, 2015, 8:30 p.m. by Wladimir Palant
Modified:
Nov. 9, 2015, 3:03 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 3129/3144 - Don`t let the findbar intercept keyboard events when editing filters

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/content/ui/filters-filterview.js View 1 chunk +6 lines, -0 lines 2 comments Download

Messages

Total messages: 3
Wladimir Palant
Nov. 6, 2015, 8:30 p.m. (2015-11-06 20:30:52 UTC) #1
Thomas Greiner
LGTM https://codereview.adblockplus.org/29329848/diff/29329849/chrome/content/ui/filters-filterview.js File chrome/content/ui/filters-filterview.js (right): https://codereview.adblockplus.org/29329848/diff/29329849/chrome/content/ui/filters-filterview.js#newcode669 chrome/content/ui/filters-filterview.js:669: event.stopPropagation() Detail: Missing semicolon.
Nov. 9, 2015, 2:43 p.m. (2015-11-09 14:43:41 UTC) #2
Wladimir Palant
Nov. 9, 2015, 3:03 p.m. (2015-11-09 15:03:50 UTC) #3
Message was sent while issue was closed.
https://codereview.adblockplus.org/29329848/diff/29329849/chrome/content/ui/f...
File chrome/content/ui/filters-filterview.js (right):

https://codereview.adblockplus.org/29329848/diff/29329849/chrome/content/ui/f...
chrome/content/ui/filters-filterview.js:669: event.stopPropagation()
On 2015/11/09 14:43:41, Thomas Greiner wrote:
> Detail: Missing semicolon.

Fixed in the patch I pushed.

Powered by Google App Engine
This is Rietveld