Issue 3224 - Unbreak filter assistant

chrome/content/ui/composer.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-var nodes = null;
+var nodesID = null;
 var item = null;
 var advancedMode = false;
 
 function init()
 {
-  [nodes, item] = window.arguments;
+  [nodesID, item] = window.arguments;
+  window.addEventListener("unload", () => Policy.deleteNodes(nodesID));
 
   E("filterType").value = (!item.filter || item.filter.disabled || item.filter instanceof WhitelistFilter ? "filterlist" : "whitelist");
   E("customPattern").value = item.location;
 
   let insertionPoint = E("customPatternBox");
   let addSuggestion = function(address)
   {
     // Always drop protocol and www. from the suggestion
     address = address.replace(/^[\w\-]+:\/+(?:www\.)?/, "");
 
@@ skipping 299 matching lines @@
   E("patternGroup").value = "";
   updatePatternSelection();
 }
 
 function addFilter() {
   let filter = Filter.fromText(document.getElementById("filter").value);
   filter.disabled = false;
 
   FilterStorage.addFilter(filter);
 
-  if (nodes)
-    Policy.refilterNodes(nodes, item);
+  if (nodesID)
+    Policy.refilterNodes(nodesID, item);
 
   return true;
 }
 
 function setAdvancedMode(mode) {
   advancedMode = mode;
 
   var dialog = document.documentElement;
   dialog.setAttribute("advancedMode", advancedMode);
 
@@ skipping 36 matching lines @@
  * Selects or unselects all type checkboxes except those
  * that are disabled.
  */
 function selectAllTypes(/**Boolean*/ select)
 {
   for (let typeNode = E("typeGroup").firstChild; typeNode; typeNode = typeNode.nextSibling)
     if (typeNode.getAttribute("disabled") != "true")
       typeNode.checked = select;
   updateFilter();
 }