Unified Diff: lib/ui.js
Issue 29329884:
Issue 3224 - Unbreak filter assistant (Closed)
Patch Set: Rebased
Created Nov. 12, 2015, 3:10 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« lib/child/contentPolicy.js ('K')
|
« lib/requestNotifier.js ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/ui.js |
| =================================================================== |
| --- a/lib/ui.js |
| +++ b/lib/ui.js |
| @@ -741,24 +741,27 @@ let UI = exports.UI = |
| loadDocLink: function(/**String*/ linkID, /**Window*/ window) |
| { |
| let link = Utils.getDocLink(linkID); |
| this.loadInBrowser(link, window); |
| }, |
| /** |
| - * Brings up the filter composer dialog to block an item. |
| + * Brings up the filter composer dialog to block an item. The optional nodesID |
| + * parameter must be a unique ID returned by |
| + * RequestNotifier.storeNodesForEntry() or similar. |
| */ |
| - blockItem: function(/**Window*/ window, /**Node*/ node, /**RequestEntry*/ item) |
| + blockItem: function(/**Window*/ window, /**string*/ nodesID, /**RequestEntry*/ item) |
| { |
| if (!item) |
| return; |
| - window.openDialog("chrome://adblockplus/content/ui/composer.xul", "_blank", "chrome,centerscreen,resizable,dialog=no,dependent", [node], item); |
| + window.openDialog("chrome://adblockplus/content/ui/composer.xul", "_blank", |
| + "chrome,centerscreen,resizable,dialog=no,dependent", nodesID, item); |
| }, |
| /** |
| * Opens filter preferences dialog or focuses an already open dialog. |
| * @param {Filter} [filter] filter to be selected |
| */ |
| openFiltersDialog: function(filter) |
| { |
« lib/child/contentPolicy.js ('K')
|
« lib/requestNotifier.js ('k')
|
no next file »
|
no next file with comments »
