Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: pages/coding-style.html

Issue 29329899: Issue 3158 - Add CSS and HTML rules to coding style page (Closed)
Patch Set: Identifiers rename, consistency changes Created Nov. 10, 2015, 10:13 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pages/coding-style.html
===================================================================
--- a/pages/coding-style.html
+++ b/pages/coding-style.html
@@ -11,44 +11,56 @@
<h2 id="general">{{s5 General}}</h2>
<ul>
-<li>{{s6 Follow the Mozilla Coding Style's <a href="https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style#General_C.2FC.2B.2B_Practices">general practices</a> and its <a href="https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style#Naming_and_Formatting_code">naming and formatting rules</a>.}}</li>
-<li>{{s7 Use 2 spaces per indentation level.}}</li>
-<li>{{s8 All files should have a <a href="license-headers">license header</a>, but no mode line comments.}}</li>
-<li>{{s9 Newline at end of file, otherwise no trailing whitespace.}}</li>
-<li>{{s10 Lines can be longer than the limit, if limiting line length would hurt readability in a particular case.}}</li>
-<li>{{s11 Opening braces always go on their own line.}}</li>
-<li>{{s12 No hungarian notation, no special variable name prefixes or suffixes denoting type or scope. All variable names start with a lower case letter.}}</li>
-<li>{{s13 Don't comment code out, delete it.}}</li>
-<li>{{todo-comments Don't add TODO comments, create an <a href="https://issues.adblockplus.org">issue</a> and reference it in a comment instead.}}</li>
+ <li>{{s6 Follow the Mozilla Coding Style's <a href="https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style#General_C.2FC.2B.2B_Practices">general practices</a> and its <a href="https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style#Naming_and_Formatting_code">naming and formatting rules</a>.}}</li>
+ <li>{{s7 Use 2 spaces per indentation level.}}</li>
+ <li>{{s8 All files should have a <a href="license-headers">license header</a>, but no mode line comments.}}</li>
+ <li>{{s9 Newline at end of file, otherwise no trailing whitespace.}}</li>
+ <li>{{s10 Lines can be longer than the limit, if limiting line length would hurt readability in a particular case.}}</li>
+ <li>{{s11 Opening braces always go on their own line.}}</li>
+ <li>{{s12 No hungarian notation, no special variable name prefixes or suffixes denoting type or scope. All variable names start with a lower case letter.}}</li>
+ <li>{{s13 Don't comment code out, delete it.}}</li>
+ <li>{{todo-comments Don't add TODO comments, create an <a href="https://issues.adblockplus.org">issue</a> and reference it in a comment instead.}}</li>
</ul>
<h2 id="javascript">{{s14 JavaScript}}</h2>
<ul>
-<li>{{s15 Follow the Mozilla Coding Style's <a href="https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style#JavaScript_practices">JavaScript practices</a>.}}</li>
-<li>{{s16 Opening braces of object literals in don't go on their own line when that would cause a syntax error.}}</li>
-<li>{{s17 Use <code>bind()</code> to ensure the desired value of the <code>this</code> variable, don’t use temporary variables as a replacement.}}</li>
-<li>{{s18 In classes, prefix private functions with a single underscore to make them pseudo-private.}}</li>
+ <li>{{s15 Follow the Mozilla Coding Style's <a href="https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style#JavaScript_practices">JavaScript practices</a>.}}</li>
+ <li>{{s16 Opening braces of object literals in don't go on their own line when that would cause a syntax error.}}</li>
+ <li>{{s17 Use <code>bind()</code> to ensure the desired value of the <code>this</code> variable, don’t use temporary variables as a replacement.}}</li>
+ <li>{{s18 In classes, prefix private functions with a single underscore to make them pseudo-private.}}</li>
+</ul>
+
+<h2 id="html-css">{{html-css HTML and CSS}}</h2>
+<ul>
+ <li>{{html-css-general Follow the <a href="https://google.github.io/styleguide/htmlcssguide.xml">Google HTML/CSS Style Guide</a>.}}</li>
+ <li>{{html-css-quotation Use double over single quotation marks.}}</li>
+ <li>{{html-css-optional-tag Don't omit optional HTML tags.}}</li>
+ <li>{{html-css-hexadecimal CSS color values should be specified in hexadecimal where possible.}}</li>
+ <li>{{html-css-shorthand CSS shorthand properties usage is optional.}}</li>
+ <li>{{html-css-order CSS rule declaration order should follow the <a href="https://make.wordpress.org/core/handbook/best-practices/coding-standards/css/#property-ordering">WordPress CSS Coding Standards</a>.}}</li>
+ <li>{{html-css-units CSS number values should specify units where possible.}}</li>
+ <li>{{html-css-leading-zero CSS number values between -1 and 1 should specify a leading 0.}}</li>
</ul>
<h2 id="python">{{s19 Python}}</h2>
<ul>
-<li>{{s20 Follow the Mozilla Coding Style's <a href="https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style#Python_Practices">Python practices</a>.}}</li>
-<li>{{s21 In modules, prefix private functions and variables with a single underscore.}}</li>
+ <li>{{s20 Follow the Mozilla Coding Style's <a href="https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style#Python_Practices">Python practices</a>.}}</li>
+ <li>{{s21 In modules, prefix private functions and variables with a single underscore.}}</li>
</ul>
<h2 id="java">{{s22 Java}}</h2>
<ul>
-<li>{{s23 Follow the Mozilla Coding Style's <a href="https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style#Java_practices">Java practices</a>.}}</li>
-<li>{{s24 Imports should be organised consistently per file, we don't use global rules.}}</li>
+ <li>{{s23 Follow the Mozilla Coding Style's <a href="https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style#Java_practices">Java practices</a>.}}</li>
+ <li>{{s24 Imports should be organised consistently per file, we don't use global rules.}}</li>
</ul>
<h2 id="cpp">{{s25 C++}}</h2>
<ul>
-<li>{{s26 Follow the Mozilla Coding Style's <a href="https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style#C.2FC.2B.2B_practices">C++ practices</a>.}}</li>
-<li>{{s27 Indent namespace bodies.}}</li>
-<li>{{s28 Avoid manual memory management: Use references and values when possible, smart pointers when necessary, raw pointers only for weak references.}}</li>
-<li>{{s29 Don't use C-style casts unless its exact semantics are required.}}</li>
-<li>{{s30 We tend to use anonymous namespaces instead of static.}}</li>
+ <li>{{s26 Follow the Mozilla Coding Style's <a href="https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style#C.2FC.2B.2B_practices">C++ practices</a>.}}</li>
+ <li>{{s27 Indent namespace bodies.}}</li>
+ <li>{{s28 Avoid manual memory management: Use references and values when possible, smart pointers when necessary, raw pointers only for weak references.}}</li>
+ <li>{{s29 Don't use C-style casts unless its exact semantics are required.}}</li>
+ <li>{{s30 We tend to use anonymous namespaces instead of static.}}</li>
</ul>
<h2 id="objc">{{objective-c Objective-C}}</h2>
@@ -58,7 +70,7 @@
<h2 id="puppet">{{s31 Puppet}}</h2>
<ul>
-<li>{{s32 Follow the <a href="http://docs.puppetlabs.com/guides/style_guide.html">Puppet Style Guide</a>.}}</li>
-<li>{{s33 Opening braces don't go on their own line.}}</li>
-<li>{{s34 Arrows should not be aligned.}}</li>
+ <li>{{s32 Follow the <a href="http://docs.puppetlabs.com/guides/style_guide.html">Puppet Style Guide</a>.}}</li>
+ <li>{{s33 Opening braces don't go on their own line.}}</li>
+ <li>{{s34 Arrows should not be aligned.}}</li>
</ul>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld