Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329904: Issue 3294 - Fix broken Android build (again) (Closed)

Created:
Nov. 10, 2015, 11:22 a.m. by René Jeschke
Modified:
Nov. 10, 2015, 12:07 p.m.
Reviewers:
Felix Dahlke
CC:
sergei
Visibility:
Public.

Description

Issue 3294 - Fix broken Android build (again)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed NL at EOF #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/AdblockPlus/Notification.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
René Jeschke
Nov. 10, 2015, 11:24 a.m. (2015-11-10 11:24:11 UTC) #1
Felix Dahlke
https://codereview.adblockplus.org/29329904/diff/29329905/include/AdblockPlus/Notification.h File include/AdblockPlus/Notification.h (right): https://codereview.adblockplus.org/29329904/diff/29329905/include/AdblockPlus/Notification.h#newcode90 include/AdblockPlus/Notification.h:90: #endif Does this add a newline at EOL? Should ...
Nov. 10, 2015, 11:31 a.m. (2015-11-10 11:31:28 UTC) #2
René Jeschke
https://codereview.adblockplus.org/29329904/diff/29329905/include/AdblockPlus/Notification.h File include/AdblockPlus/Notification.h (right): https://codereview.adblockplus.org/29329904/diff/29329905/include/AdblockPlus/Notification.h#newcode90 include/AdblockPlus/Notification.h:90: #endif On 2015/11/10 11:31:28, Felix Dahlke wrote: > Does ...
Nov. 10, 2015, 11:38 a.m. (2015-11-10 11:38:21 UTC) #3
Felix Dahlke
Nov. 10, 2015, 11:39 a.m. (2015-11-10 11:39:18 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld