Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: src/org/adblockplus/libadblockplus/ShowNotificationCallback.java

Issue 29329928: Issue 3297 - Fix issues introduced by recent libadblockplus changes and update dependencies (Closed)
Patch Set: Created Nov. 10, 2015, 4:32 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2015 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 package org.adblockplus.libadblockplus; 18 package org.adblockplus.libadblockplus;
19 19
20 public abstract class UpdateAvailableCallback implements Disposable 20 public abstract class ShowNotificationCallback implements Disposable
Felix Dahlke 2015/11/20 07:53:52 This change looks strange, isn't this a new file?
René Jeschke 2015/11/20 12:19:15 It actually is a new file, git also displays it as
Felix Dahlke 2015/11/20 12:21:28 OK, thought so. Maybe it has to do with Git's magi
21 { 21 {
22 private final Disposer disposer; 22 private final Disposer disposer;
23 protected final long ptr; 23 protected final long ptr;
24 24
25 static 25 static
26 { 26 {
27 System.loadLibrary("adblockplus-jni"); 27 System.loadLibrary("adblockplus-jni");
28 registerNatives(); 28 registerNatives();
29 } 29 }
30 30
31 public UpdateAvailableCallback() 31 public ShowNotificationCallback()
32 { 32 {
33 this.ptr = ctor(this); 33 this.ptr = ctor(this);
34 this.disposer = new Disposer(this, new DisposeWrapper(this.ptr)); 34 this.disposer = new Disposer(this, new DisposeWrapper(this.ptr));
35 } 35 }
36 36
37 public abstract void updateAvailableCallback(String url); 37 public abstract void showNotificationCallback(Notification jsValue);
38 38
39 @Override 39 @Override
40 public void dispose() 40 public void dispose()
41 { 41 {
42 this.disposer.dispose(); 42 this.disposer.dispose();
43 } 43 }
44 44
45 private final static class DisposeWrapper implements Disposable 45 private final static class DisposeWrapper implements Disposable
46 { 46 {
47 private final long ptr; 47 private final long ptr;
48 48
49 public DisposeWrapper(final long ptr) 49 public DisposeWrapper(final long ptr)
50 { 50 {
51 this.ptr = ptr; 51 this.ptr = ptr;
52 } 52 }
53 53
54 @Override 54 @Override
55 public void dispose() 55 public void dispose()
56 { 56 {
57 dtor(this.ptr); 57 dtor(this.ptr);
58 } 58 }
59 } 59 }
60 60
61 private final static native void registerNatives(); 61 private final static native void registerNatives();
62 62
63 private final static native long ctor(Object callbackObject); 63 private final static native long ctor(Object callbackObject);
64 64
65 private final static native void dtor(long ptr); 65 private final static native void dtor(long ptr);
66 } 66 }
OLDNEW
« jni/JniFilterEngine.cpp ('K') | « src/org/adblockplus/libadblockplus/FilterEngine.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld