Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Delta Between Two Patch Sets: pages/uninstall-abp.tmpl

Issue 29329984: Issue 3257 - Create uninstallation page in adblockplus.org (Closed)
Left Patch Set: Rename logo to make it consistent Created Nov. 12, 2015, 4:10 p.m.
Right Patch Set: Convert to array instead of cloning Created Dec. 3, 2015, 1:55 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | pages/uninstall-abp-submit.md » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 title=Adblock Plus has been uninstalled 1 title=Adblock Plus has been uninstalled
2 template=simple 2 template=simple
3 3
4 {% set reasons = [ 4 {% set reasons = [
kzar 2015/11/16 10:55:19 I don't think this page should really be a templat
saroyanm 2015/11/17 15:27:49 I forgot to mention in the ticket that the reasons
kzar 2015/11/18 17:14:44 Acknowledged.
5 ("1v0", "reason-not-installed", "I didn't install Adblock Plus."), 5 ("1v0", "reason-not-installed", "I didn't install Adblock Plus."),
6 ("2v0", "reason-slowing-down", "Adblock Plus slowed down my browser."), 6 ("2v0", "reason-slowing-down", "Adblock Plus slowed down my browser."),
7 ("3v0", "reason-acceptable-ads", "I don't like the Acceptable Ads program.") , 7 ("3v0", "reason-acceptable-ads", "I don't like the Acceptable Ads program."),
8 ("4v0", "reason-see-ads", "Adblock Plus didn't block all ads."), 8 ("4v0", "reason-see-ads", "Adblock Plus didn't block all ads."),
9 ("5v0", "reason-better-adblocker", "I found better ad blocking software."), 9 ("5v0", "reason-better-adblocker", "I found better ad blocking software."),
10 ("6v0", "reason-break-websites", "Adblock Plus breaks websites that I visit. ") 10 ("6v0", "reason-break-websites", "Adblock Plus breaks websites that I visit.")
11 ] %} 11 ] %}
12 12
13 <head> 13 <head>
14 <meta name="robots" content="noindex" /> 14 <meta name="robots" content="noindex" />
15
16 <script type="text/javascript"> 15 <script type="text/javascript">
17 (function() 16 (function()
18 { 17 {
19 function init() 18 function init()
20 { 19 {
21 var form = document.getElementById("reasons-form"); 20 var form = document.getElementById("reasons-form");
21
22 // Create hidden input for GET parameters
22 window.location.search.substr(1).split("&").forEach(function(param) 23 window.location.search.substr(1).split("&").forEach(function(param)
23 { 24 {
24 if (!/.=./.test(param)) 25 if (!/.=./.test(param))
25 return; 26 return;
26 27
27 var paramSplit = param.split("="); 28 var paramSplit = param.split("=");
28 var input = document.createElement("input"); 29 var input = document.createElement("input");
29 input.setAttribute("type", "hidden"); 30 input.setAttribute("type", "hidden");
30 input.setAttribute("name", paramSplit[0]); 31 input.setAttribute("name", paramSplit[0]);
31 input.setAttribute("value", paramSplit[1]); 32 input.setAttribute("value", paramSplit[1]);
32 form.appendChild(input); 33 form.appendChild(input);
33 }); 34 });
34 35
35 document.getElementById("reason-other").addEventListener("change", 36 // Randomly add reasons
36 function() 37 var reasonsContainer = document.getElementById("reasons");
38 var reasons = reasonsContainer.getElementsByTagName("li");
39 reasons = Array.prototype.slice.call(reasons);
40 reasonsContainer.innerHTML = "";
41 while (reasons.length)
42 {
43 var randomIndex = Math.floor(Math.random() * (reasons.length -1));
44 var reasonElement = reasons.splice(randomIndex, 1)[0];
45 reasonsContainer.appendChild(reasonElement);
46 }
47
48 var reasonOtherCheckbox = document.getElementById("reason-other");
49 reasonOtherCheckbox.addEventListener("change", function()
37 { 50 {
38 var textArea = document.getElementById("reason-other-input"); 51 var textArea = document.getElementById("reason-other-input");
39 textArea.hasAttribute("class") ? textArea.removeAttribute("class") : 52 if (textArea.hasAttribute("class"))
40 textArea.setAttribute("class", "hidden"); 53 textArea.removeAttribute("class")
54 else
55 textArea.setAttribute("class", "hidden");
41 }, false); 56 }, false);
42 57
43 document.getElementById("submit-form").addEventListener("click", 58 var submitButton = document.getElementById("submit-form");
44 function(event) 59 submitButton.addEventListener("click", function(event)
45 { 60 {
46 if (!document.querySelector("ul input:checked")) 61 if (!document.querySelector("ul input:checked"))
47 { 62 {
48 event.preventDefault(); 63 event.preventDefault();
49 form.setAttribute("class", "error"); 64 form.setAttribute("class", "error");
65 }
66 else
67 {
68 form.submit();
50 } 69 }
51 }, false); 70 }, false);
52 } 71 }
53 document.addEventListener("DOMContentLoaded", init, false); 72 document.addEventListener("DOMContentLoaded", init, false);
54 })(); 73 })();
55 </script> 74 </script>
56 </head> 75 </head>
76
57 <section class="highlighted"> 77 <section class="highlighted">
58 <h1>{{"Please select the reason(s) why you uninstalled Adblock Plus:"|translat e("reasons-header", "Form heading")}}</h1> 78 <h1>{{"Please select the reason(s) why you uninstalled Adblock Plus:"|translat e("reasons-header", "Form heading")}}</h1>
59 <form id="reasons-form" action="uninstall-abp-submit" method="post"> 79 <form id="reasons-form" action="uninstall-abp-submit" method="post">
60 <ul> 80 <ul id="reasons">
61 {%- for reasonId, stringId, value in reasons|shuffle %} 81 {%- for reasonId, stringId, value in reasons %}
kzar 2015/11/16 10:55:19 The shuffling should be done on the client side, i
saroyanm 2015/11/17 15:27:49 How stupid am I, thanks for clearing that out :/
62 <li> 82 <li>
63 <label> 83 <label>
64 <input type="checkbox" name="reason" value="{{reasonId}}" /> 84 <input type="checkbox" name="reason" value="{{reasonId}}" />
65 <span>{{value|translate(stringId, "One of the listed uninstallation re ason")}}</span> 85 {{value|translate(stringId, "Uninstallation reason")}}
66 </label> 86 </label>
67 </li> 87 </li>
68 {%- endfor %} 88 {%- endfor %}
69 <li> 89 <li>
70 <label> 90 <label>
71 <input id="reason-other" type="checkbox" name="reason" value="0v0" /> 91 <input id="reason-other" type="checkbox" name="reason" value="0v0" />
72 <span>{{"Other, namely..."|translate("reason-other", "Last uninstallat ion reason")}}</span> 92 {{"Other, namely..."|translate("reason-other", "Last uninstallation re ason")}}
73 </label> 93 </label>
74 <textarea id="reason-other-input" class="hidden" name="reasonOther" plac eholder="{{"Please explain why you are uninstalling Adblock Plus"|translate("rea son-other-placeholder", "Textarea placeholder text, appears after selecting 'Oth er, namely...' option")}}"></textarea> 94 <textarea id="reason-other-input" class="hidden" name="reasonOther" plac eholder="{{"Please explain why you are uninstalling Adblock Plus"|translate("rea son-other-placeholder", "Textarea placeholder text, appears after selecting 'Oth er, namely...' option")}}"></textarea>
75 </li> 95 </li>
76 </ul> 96 </ul>
77 <button id="submit-form" type="submit">{{"Submit"|translate("submit", "Submi t button text")}}</button> 97 <button id="submit-form">{{"Submit"|translate("submit", "Submit button text" )}}</button>
78 <span class="error-label">{{"Please select at least one of the options above "|translate("error-msg", "Error message, is being shown after submission if no i tem selected")}}</span> 98 <span class="error-label">{{"Please select at least one of the options above "|translate("error-msg", "Error message, is being shown after submission if no i tem selected")}}</span>
79 </form> 99 </form>
80 <p class="disclaimer">{{"By clicking Submit, you are sending your response to Adblock Plus. Please see our <a href='https://adblockplus.org/privacy'>privacy p olicy</a>."|translate("disclaimer", "Disclaimer below form")}}</p> 100 <p class="disclaimer">
101 {{"By clicking Submit, you are sending your response to Adblock Plus. Please see our <a href='/privacy'>privacy policy</a>."|translate("disclaimer", "Discla imer below form")}}
102 </p>
81 </section> 103 </section>
LEFTRIGHT
« no previous file | pages/uninstall-abp-submit.md » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld