Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Delta Between Two Patch Sets: pages/uninstall-abp.tmpl

Issue 29329984: Issue 3257 - Create uninstallation page in adblockplus.org (Closed)
Left Patch Set: Removed section from template Created Nov. 20, 2015, 6:29 p.m.
Right Patch Set: Convert to array instead of cloning Created Dec. 3, 2015, 1:55 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | pages/uninstall-abp-submit.md » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 title=Adblock Plus has been uninstalled 1 title=Adblock Plus has been uninstalled
2 template=simple 2 template=simple
3
4 {% set reasons = [
5 ("1v0", "reason-not-installed", "I didn't install Adblock Plus."),
6 ("2v0", "reason-slowing-down", "Adblock Plus slowed down my browser."),
7 ("3v0", "reason-acceptable-ads", "I don't like the Acceptable Ads program."),
8 ("4v0", "reason-see-ads", "Adblock Plus didn't block all ads."),
9 ("5v0", "reason-better-adblocker", "I found better ad blocking software."),
10 ("6v0", "reason-break-websites", "Adblock Plus breaks websites that I visit.")
11 ] %}
3 12
4 <head> 13 <head>
5 <meta name="robots" content="noindex" /> 14 <meta name="robots" content="noindex" />
6 <script type="text/javascript"> 15 <script type="text/javascript">
7 (function() 16 (function()
8 { 17 {
9 var reasons = [
saroyanm 2015/11/20 18:36:17 I've just noticed that the syntax highlighting bei
kzar 2015/11/21 19:01:25 Perhaps mixing " and 's would make it easier for y
saroyanm 2015/11/23 10:50:31 Yes, yes, but from point of view making it as mana
10 ["1v0", "{{"I didn't install Adblock Plus."|translate("reason-not-installe d", "reason")}}"],
11 ["2v0", "{{"Adblock Plus slowed down my browser."|translate("reason-slowin g-down", "reason")}}"],
12 ["3v0", "{{"I don't like the Acceptable Ads program."|translate("reason-ac ceptable-ads", "reason")}}"],
13 ["4v0", "{{"Adblock Plus didn't block all ads."|translate("reason-see-ads" , "reason")}}"],
14 ["5v0", "{{"I found better ad blocking software."|translate("reason-better -adblocker", "reason")}}"],
15 ["6v0", "{{"Adblock Plus breaks websites that I visit."|translate("reason- break-websites", "reason")}}"]
16 ];
17
18 function init() 18 function init()
19 { 19 {
20 var form = document.getElementById("reasons-form"); 20 var form = document.getElementById("reasons-form");
21 21
22 // Create hidden input for GET parameters 22 // Create hidden input for GET parameters
23 window.location.search.substr(1).split("&").forEach(function(param) 23 window.location.search.substr(1).split("&").forEach(function(param)
24 { 24 {
25 if (!/.=./.test(param)) 25 if (!/.=./.test(param))
26 return; 26 return;
27 27
28 var paramSplit = param.split("="); 28 var paramSplit = param.split("=");
29 var input = document.createElement("input"); 29 var input = document.createElement("input");
30 input.setAttribute("type", "hidden"); 30 input.setAttribute("type", "hidden");
31 input.setAttribute("name", paramSplit[0]); 31 input.setAttribute("name", paramSplit[0]);
32 input.setAttribute("value", paramSplit[1]); 32 input.setAttribute("value", paramSplit[1]);
33 form.appendChild(input); 33 form.appendChild(input);
34 }); 34 });
35 35
36 // Randomly add reasons 36 // Randomly add reasons
37 while (reasons.length > 0) 37 var reasonsContainer = document.getElementById("reasons");
38 var reasons = reasonsContainer.getElementsByTagName("li");
39 reasons = Array.prototype.slice.call(reasons);
40 reasonsContainer.innerHTML = "";
41 while (reasons.length)
38 { 42 {
39 var randomIndex = Math.floor(Math.random() * (reasons.length)); 43 var randomIndex = Math.floor(Math.random() * (reasons.length -1));
40 var reason = reasons.splice(randomIndex, 1)[0]; 44 var reasonElement = reasons.splice(randomIndex, 1)[0];
41 var listElement = document.createElement("li"); 45 reasonsContainer.appendChild(reasonElement);
42 var labelElement = document.createElement("label");
43 var checkboxElement = document.createElement("input");
44 checkboxElement.setAttribute("type", "checkbox");
45 checkboxElement.setAttribute("name", "reason");
46 checkboxElement.setAttribute("value", reason[0]);
47 var spanElement = document.createElement("span");
48 spanElement.innerHTML = reason[1];
49 labelElement.appendChild(checkboxElement);
50 labelElement.appendChild(spanElement);
51 listElement.appendChild(labelElement);
52 var reasonContainer = document.getElementById("reasons");
53 reasonContainer.insertBefore(listElement, reasonContainer.firstChild);
54 } 46 }
55 47
56 document.getElementById("reason-other").addEventListener("change", 48 var reasonOtherCheckbox = document.getElementById("reason-other");
57 function() 49 reasonOtherCheckbox.addEventListener("change", function()
58 { 50 {
59 var textArea = document.getElementById("reason-other-input"); 51 var textArea = document.getElementById("reason-other-input");
60 textArea.hasAttribute("class") ? textArea.removeAttribute("class") : 52 if (textArea.hasAttribute("class"))
61 textArea.setAttribute("class", "hidden"); 53 textArea.removeAttribute("class")
54 else
55 textArea.setAttribute("class", "hidden");
62 }, false); 56 }, false);
63 57
64 document.getElementById("submit-form").addEventListener("click", 58 var submitButton = document.getElementById("submit-form");
65 function(event) 59 submitButton.addEventListener("click", function(event)
66 { 60 {
67 if (!document.querySelector("ul input:checked")) 61 if (!document.querySelector("ul input:checked"))
68 { 62 {
69 event.preventDefault(); 63 event.preventDefault();
70 form.setAttribute("class", "error"); 64 form.setAttribute("class", "error");
71 } 65 }
72 else 66 else
67 {
73 form.submit(); 68 form.submit();
69 }
74 }, false); 70 }, false);
75 } 71 }
76 document.addEventListener("DOMContentLoaded", init, false); 72 document.addEventListener("DOMContentLoaded", init, false);
77 })(); 73 })();
78 </script> 74 </script>
79 </head> 75 </head>
80 76
81 <section class="highlighted"> 77 <section class="highlighted">
82 <? include uninstall-abp ?> 78 <h1>{{"Please select the reason(s) why you uninstalled Adblock Plus:"|translat e("reasons-header", "Form heading")}}</h1>
79 <form id="reasons-form" action="uninstall-abp-submit" method="post">
80 <ul id="reasons">
81 {%- for reasonId, stringId, value in reasons %}
82 <li>
83 <label>
84 <input type="checkbox" name="reason" value="{{reasonId}}" />
85 {{value|translate(stringId, "Uninstallation reason")}}
86 </label>
87 </li>
88 {%- endfor %}
89 <li>
90 <label>
91 <input id="reason-other" type="checkbox" name="reason" value="0v0" />
92 {{"Other, namely..."|translate("reason-other", "Last uninstallation re ason")}}
93 </label>
94 <textarea id="reason-other-input" class="hidden" name="reasonOther" plac eholder="{{"Please explain why you are uninstalling Adblock Plus"|translate("rea son-other-placeholder", "Textarea placeholder text, appears after selecting 'Oth er, namely...' option")}}"></textarea>
95 </li>
96 </ul>
97 <button id="submit-form">{{"Submit"|translate("submit", "Submit button text" )}}</button>
98 <span class="error-label">{{"Please select at least one of the options above "|translate("error-msg", "Error message, is being shown after submission if no i tem selected")}}</span>
99 </form>
100 <p class="disclaimer">
101 {{"By clicking Submit, you are sending your response to Adblock Plus. Please see our <a href='/privacy'>privacy policy</a>."|translate("disclaimer", "Discla imer below form")}}
102 </p>
83 </section> 103 </section>
LEFTRIGHT
« no previous file | pages/uninstall-abp-submit.md » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld