src/plugin/PluginWbPassThrough.cpp - Issue 29330053: Issue 3303 - Unescape request URL for ShouldBlock in WBPassthruSink::BeginningTransaction

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/plugin/PluginWbPassThrough.cpp

Issue 29330053: Issue 3303 - Unescape request URL for ShouldBlock in WBPassthruSink::BeginningTransaction (Closed)

Patch Set: address comment Created Nov. 16, 2015, 9:56 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/plugin/PluginWbPassThrough.cpp

diff --git a/src/plugin/PluginWbPassThrough.cpp b/src/plugin/PluginWbPassThrough.cpp

index b50c16a30ce86cf749d45debc8b175363c3869b3..5a77b7267078b9c271bd45d1374e0ff3111a7123 100644

--- a/src/plugin/PluginWbPassThrough.cpp

+++ b/src/plugin/PluginWbPassThrough.cpp

@@ -378,7 +378,7 @@ STDMETHODIMP WBPassthruSink::BeginningTransaction(LPCWSTR szURL, LPCWSTR szHeade

m_contentType = ContentType::CONTENT_TYPE_XMLHTTPREQUEST;

}

- if (client->ShouldBlock(szURL, m_contentType, m_boundDomain, /*debug flag but must be set*/true))

+ if (client->ShouldBlock(src, m_contentType, m_boundDomain, /*debug flag but must be set*/true))

{

// NOTE: Feeding custom HTML to Flash, instead of original object subrequest

// doesn't have much sense. It also can manifest in unwanted result

« no previous file with comments | « no previous file | no next file » | no next file with comments »