Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29330186: Issue 3319 - Save build manifest with the same base name as the APK (Closed)

Created:
Nov. 13, 2015, 12:46 p.m. by Felix Dahlke
Modified:
Nov. 13, 2015, 4:08 p.m.
Reviewers:
René Jeschke
Visibility:
Public.

Description

Issue 3319 - Save build manifest with the same base name as the APK

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add missing import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build.py View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Felix Dahlke
Haven't tested this with a full build yet, will do that before pushing though.
Nov. 13, 2015, 12:46 p.m. (2015-11-13 12:46:56 UTC) #1
René Jeschke
https://codereview.adblockplus.org/29330186/diff/29330187/build.py File build.py (right): https://codereview.adblockplus.org/29330186/diff/29330187/build.py#newcode86 build.py:86: target_manifest_path = re.sub(r".apk$", ".json", target_apk_path) `re` is not imported ...
Nov. 13, 2015, 12:50 p.m. (2015-11-13 12:50:46 UTC) #2
Felix Dahlke
New patch set up, but still didn't finish the integration test, it takes a while. ...
Nov. 13, 2015, 12:53 p.m. (2015-11-13 12:53:31 UTC) #3
René Jeschke
Nov. 13, 2015, 12:54 p.m. (2015-11-13 12:54:15 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld