Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(461)

Issue 29330205: Issue 3318 - Serve release update manifests for Adblock Browser (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Felix Dahlke
Modified:
4 years, 3 months ago
Reviewers:
mathias, Fred
Visibility:
Public.

Description

Issue 3318 - Serve release update manifests for Adblock Browser

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove $query_string from the cache key, add missing sitescripts.ini entries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M modules/downloadserver/files/site.conf View 1 1 chunk +2 lines, -2 lines 0 comments Download
M modules/downloadserver/files/sitescripts View 1 1 chunk +2 lines, -0 lines 0 comments Download
M modules/updateserver/files/site.conf View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Felix Dahlke
4 years, 3 months ago (2015-11-13 19:22:30 UTC) #1
Fred
LGTM
4 years, 3 months ago (2015-11-19 12:29:58 UTC) #2
mathias
https://codereview.adblockplus.org/29330205/diff/29330206/modules/downloadserver/files/site.conf File modules/downloadserver/files/site.conf (right): https://codereview.adblockplus.org/29330205/diff/29330206/modules/downloadserver/files/site.conf#newcode26 modules/downloadserver/files/site.conf:26: fastcgi_cache_key "$request_uri $query_string"; Please use a question mark instead ...
4 years, 3 months ago (2015-11-19 12:40:06 UTC) #3
Felix Dahlke
New patch set is up, did some integration testing and realised I had forgotton to ...
4 years, 3 months ago (2015-11-19 15:44:40 UTC) #4
mathias
4 years, 3 months ago (2015-11-19 19:30:10 UTC) #5
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5