Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29330318: Issue 3332 - Update adblockplus dependency to revision 4f4db95e3e35 (Closed)

Created:
Nov. 17, 2015, 4:42 p.m. by kzar
Modified:
Nov. 18, 2015, 10 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 3332 - Update adblockplus dependency to revision 4f4db95e3e35

Patch Set 1 #

Total comments: 2

Patch Set 2 : Don't use the release branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M dependencies View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1
Nov. 17, 2015, 4:43 p.m. (2015-11-17 16:43:27 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29330318/diff/29330319/dependencies File dependencies (right): https://codereview.adblockplus.org/29330318/diff/29330319/dependencies#newcode4 dependencies:4: adblockplus = adblockplus hg:38734339b8a8 git:2af0272 Please don't set dependency ...
Nov. 17, 2015, 6:43 p.m. (2015-11-17 18:43:39 UTC) #2
kzar
Patch Set 2 : Don't use the release branch https://codereview.adblockplus.org/29330318/diff/29330319/dependencies File dependencies (right): https://codereview.adblockplus.org/29330318/diff/29330319/dependencies#newcode4 dependencies:4: ...
Nov. 17, 2015, 6:54 p.m. (2015-11-17 18:54:43 UTC) #3
Wladimir Palant
Nov. 18, 2015, 9:48 a.m. (2015-11-18 09:48:34 UTC) #4
LGTM assuming that you actually tested this (quite a few changes there, not
supposed to break Chrome but still).

Powered by Google App Engine
This is Rietveld