metadata.common - Issue 29330321: Issue 3334 - Fix warnings spotted during testing before release

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: metadata.common

Issue 29330321: Issue 3334 - Fix warnings spotted during testing before release (Closed)

Patch Set: Remove changes to webrequest.js Created Nov. 17, 2015, 7:04 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: metadata.common

diff --git a/metadata.common b/metadata.common

index dc7b8c36bff5b9d1603e9209fc8e67ab4e44955c..06bc33a06498df226bad11bc66317de1346172f3 100644

--- a/metadata.common

+++ b/metadata.common

@@ -18,7 +18,6 @@ testScripts = ../ext/common.js

../ext/background.js

../lib/compat.js

../lib/info.js

- ../lib/io.js

../lib/adblockplus.js

../lib/publicSuffixList.js

../lib/punycode.js

@@ -46,6 +45,7 @@ firstRun.html = adblockplusui/firstRun.html

firstRun.js = adblockplusui/firstRun.js

i18n.js = adblockplusui/i18n.js

messageResponder.js = adblockplusui/messageResponder.js

+skin/abp-128.png = adblockplusui/skin/abp-128.png

Sebastian Noack 2015/11/17 20:39:43 We have following code in firstRun.js specifically

kzar 2015/11/17 21:04:15 Whoops OK, that makes sense. Done.

icons/detailed/abp-128.png = adblockplusui/skin/abp-128.png

skin/firstRun.css = adblockplusui/skin/firstRun.css

skin/ajax-loader.gif = adblockplusui/skin/ajax-loader.gif

« no previous file with comments | « lib/whitelisting.js ('k') | no next file » | no next file with comments »